Fix placement icon color and improve parent-child orchestration#1054
Merged
Conversation
The red color was over-alarming.
Test case: - root@dev2n1:~/dev/om3# om relative1 config show [DEFAULT] id = 5b025eea-c70c-4d19-b0a6-6c26c27267c0 children = relative2 relative3 nodes = * orchestrate = ha [fs#1] type = flag [app#1] start = /usr/bin/sleep 10 - root@dev2n1:~/dev/om3# om relative2 config show [DEFAULT] id = 985af049-ce59-466b-811a-a5fdb23636e5 parents = relative1 nodes = * orchestrate = ha [fs#1] type = flag [app#1] stop = /usr/bin/sleep 10 - root@dev2n1:~/dev/om3# om relative3 config show [DEFAULT] id = 9221ef4b-02ca-493a-a990-9ac195072c4e parents = relative1 nodes = * orchestrate = ha [fs#1] type = flag - root@dev2n1:~/dev/om3# om relative[123] switch -w Objects ~ rel* dev2n1 dev2n2 dev2n3 relative1 up no 1/1 | O^ wait children >placed@ X stopped >placed@ X wait children >placed @ relative2 up^ no 1/1 | X^ O X relative3 up^ no 1/1 | X^ O X The orchestration hangs at this point, because relative[23] have switched before relative1 could acknowledge the moment relative[23] were both stopped. This patch adds a isAnyParentWaitingChilren() function to create this missing synchronisation step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.