Skip to content

Reapply "OCPBUGS-55506: Prevent startup failures due to name resolution"#677

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
rfredette:reapply-ocpbugs-55506
May 6, 2026
Merged

Reapply "OCPBUGS-55506: Prevent startup failures due to name resolution"#677
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
rfredette:reapply-ocpbugs-55506

Conversation

@rfredette
Copy link
Copy Markdown
Contributor

This reverts commit ac22e22.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 22, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rfredette: This pull request references Jira Issue OCPBUGS-55506, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit ac22e22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from Miciah and frobware September 22, 2025 19:51
@candita
Copy link
Copy Markdown
Contributor

candita commented Sep 24, 2025

Just adding a hold so it doesn't get merged accidentally.
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2025
@rhamini3
Copy link
Copy Markdown

Verified using same reproducing method on clusterversion: 4.20.0-0-2025-09-26-152646-test-ci-ln-s4t5v7b-latest

Router logs show no error and router pods are successfully recreated after being deleted

I0926 17:15:59.232866       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 using PROXY protocol ...\n - Health check ok : 0 retry attempt(s).\n"

/verified by rhamini3

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 26, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamini3: This PR has been marked as verified by rhamini3.

Details

In response to this:

Verified using same reproducing method on clusterversion: 4.20.0-0-2025-09-26-152646-test-ci-ln-s4t5v7b-latest

Router logs show no error and router pods are successfully recreated after being deleted

I0926 17:15:59.232866       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 using PROXY protocol ...\n - Health check ok : 0 retry attempt(s).\n"

/verified by rhamini3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohara
Copy link
Copy Markdown
Contributor

rohara commented Dec 16, 2025

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b61bb7fe-1fa3-46bf-b8fb-be81ecaf0e0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bentito
Copy link
Copy Markdown
Contributor

bentito commented Apr 30, 2026

@coderabbitai are the current check fails due to infra flakes or code changes in this PR?

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get current check runs for the PR
gh pr checks 677 --repo openshift/router 2>&1 | head -80

Length of output: 4513


@bentito: Based on the current check results, the failures appear to be infra flakes rather than code-related issues. Here's the evidence:

Check Status BaseSHA
e2e-metal-ipi-ovn-router ❌ FAIL b231c65b
e2e-metal-ipi-ovn-dualstack ✅ PASS b231c65b (same)
e2e-metal-ipi-ovn-ipv6 ✅ PASS b231c65b (same)
e2e-aws-fips ❌ FAIL 896390778
fips-image-scan-haproxy-router ✅ PASS 896390778 (same)
unit, verify, verify-deps, images ✅ PASS

Key observations:

  1. e2e-metal-ipi-ovn-router failed, but e2e-metal-ipi-ovn-dualstack and e2e-metal-ipi-ovn-ipv6 both passed against the exact same BaseSHA — if the failure were code-related, the other metal-ipi jobs would likely also fail.
  2. e2e-aws-fips failed while fips-image-scan-haproxy-router passed against the exact same BaseSHA — same pattern.
  3. All core checks (unit, verify, verify-deps) passed cleanly.
  4. The PR was already manually verified by rhamini3 on a real cluster, and rohara issued a /retest earlier suggesting maintainers also suspected flakes.

A /retest on the failing jobs should be sufficient to clear them.

@bentito
Copy link
Copy Markdown
Contributor

bentito commented Apr 30, 2026

/retest

@bentito
Copy link
Copy Markdown
Contributor

bentito commented Apr 30, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2026
@bentito
Copy link
Copy Markdown
Contributor

bentito commented May 6, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented May 6, 2026

We have not been able to reproduce the panic that the change was causing the first time we merged it. Because the panic is so rare, we likely need a very large number of CI runs to observe the issue. The plan therefore is to merge the PR again and monitor CI for coredumps, and to do the merge ASAP after branch cut (which was more than 3 weeks ago) so we can fix this early in the development cycle and minimize disruption to other teams.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@rfredette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 6c4ca66 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 65271d2 and 2 for PR HEAD 6c4ca66 in total

@openshift-merge-bot openshift-merge-bot Bot merged commit b75bab2 into openshift:master May 6, 2026
18 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rfredette: Jira Issue OCPBUGS-55506: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55506 has been moved to the MODIFIED state.

Details

In response to this:

This reverts commit ac22e22.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants