Repository navigation
RHIDP-18822: rhdh: demote the OCP 4.20 Hive pool to on-demand - #89102
openshift-merge-bot[bot] merged 1 commit into
Conversation
OCP 4.22 becomes the RHDH default platform in the companion PR, so rhdh-4-20-us-east-2 no longer needs warm capacity. The 4.20 pool keeps only the three weekly version-matrix jobs, on different days, so size 0 / maxSize 3 is enough and clusters are built on demand. Merge this after the 4.22 pool and the claim switch: demoting 4.20 while the default jobs still claim it would push every required presubmit onto a cold pool of maxSize 3. Assisted-by: OpenCode
|
@zdrapela: This pull request references RHIDP-18822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. WalkthroughThe ClusterPool configuration sets ChangesClusterPool capacity
Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk:
|
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri, zdrapela The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zdrapela: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Part 2 of RHIDP-18822, split out of #88842 so the 4.20 capacity and the 4.22 switch can be reviewed and merged separately.
OCP 4.22 becomes the RHDH default platform in #88842, so
rhdh-4-20-us-east-2no longer needs warm capacity. It only serves the three weekly version-matrix jobs, on different days, sosize: 0/maxSize: 3is enough and clusters are built on demand.Jira: https://redhat.atlassian.net/browse/RHIDP-18822
Why a separate PR
Demoting this pool while the default claims still point at 4.20 would push every required
e2e-ocp-helmpresubmit onto a cold pool ofmaxSize: 3, so it must land after #88842, not before. Keeping it separate means the merge order is explicit and the 4.22 switch can be reverted without also giving 4.20 its warm capacity back.Testing
git diff --checkclean; one file, no generated content.hive-pools-rhdhautomatically; existing 4.20 clusters are removed as they drain, and on-demand builds stay available up tomaxSize: 3.Assisted-by: OpenCode
Summary by CodeRabbit
This change reduces the OCP 4.20 Hive cluster pool for RHDH from a warm pool to an on-demand pool. The pool is
rhdh-4-20-us-east-2, defined inclusters/hosted-mgmt/hive-pools-rhdh/rhdh-ocp-4-20-0-amd64-aws-us-east-2_clusterpool.yaml.Changes in the ClusterPool spec:
maxSizechanges from 25 to 3. The pool can hold at most three clusters.sizechanges from 6 to 0. The pool keeps no pre-provisioned clusters. Clusters are created only when claimed.runningCount: 3is removed. The pool no longer keeps a fixed number of running clusters.The AWS platform, credentials reference, region (
us-east-2), pull secret reference, and owner label are unchanged.Operational effect:
hive-pools-rhdhpath automatically. The change takes effect after sync.e2e-ocp-helmpresubmits could wait on a cold pool while default claims still target 4.20. The diff does not show this ordering. It comes from the PR description.Review effort: low. One file changed, with 2 lines added and 3 lines removed.