[DNM] Sync Serverless CI config/serverless-operator.yaml

[maschmid]

testing openshift-knative/hack#965

Summary by CodeRabbit

• Chores
  • Updated CI operator configuration for Serverless Operator builds.
  • Added new test definitions for kitchensink upgrade workflows on OCP 4.20.
  • Modified test suite for OCP 4.21, including updates to test targets and job definitions.

[maschmid]

/hold

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e69f63d0-6696-4aef-8e6b-ed6dd4411831

📥 Commits

Reviewing files that changed from the base of the PR and between 2f4532c and 3450115.

⛔ Files ignored due to path filters (2)

• ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (3)

• ci-operator/config/openshift-knative/serverless-operator/.config.prowgen
• ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml
• ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml

---

Walkthrough

Configuration updates to the serverless-operator CI/build system: a prowgen configuration receives a new empty rehearsals map, a new operator configuration file is added for the 4.20 release with build image definitions and test jobs, and an existing 4.21 configuration is revised to remove and reorganize test definitions.

Changes

Cohort / File(s)	Summary
Prowgen Configuration ci-operator/config/openshift-knative/serverless-operator/.config.prowgen	Introduces a new top-level rehearsals map initialized as an empty object while preserving existing slack_reporter settings.
CI Operator Configuration - 4.20 Release ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml	New CI configuration file defining build inputs, multiple output images (operator, must-gather, catalog, source, ingress, metadata webhook), base image references, and kitchensink upgrade test jobs with build trigger set to effectively never run.
CI Operator Configuration - 4.21 Release ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml	Removes kitchensink-e2e-c and non-suffixed kitchensink-upgrade test definitions; modifies kitchensink-upgrade-c to execute make kitchensink-e2e instead of make kitchensink-upgrade.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title references a configuration sync task but lacks specificity about the actual changes being made to the Serverless CI configuration.	Clarify the title to describe the specific changes, such as 'Add 4.20 kitchensink upgrade test configuration for Serverless operator' or 'Update Serverless operator CI test definitions for 4.20 and 4.21'.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI/CD configuration files (.config.prowgen and YAML), not Ginkgo test definitions in Go code.
Test Structure And Quality	✅ Passed	PR modifies only CI/CD infrastructure configuration files (prowgen and YAML), not Ginkgo test code. Check not applicable.
Microshift Test Compatibility	✅ Passed	This PR modifies only CI operator configuration files (YAML/prowgen), not actual test code. No new Ginkgo e2e tests or test source code with MicroShift compatibility concerns were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only CI/CD configuration files (YAML and .config.prowgen) without adding Ginkgo e2e tests, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes are CI configuration files only, not Kubernetes deployment manifests or operator code with scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check detects improper stdout writes in Go code compiled into OTE binaries. This PR only modifies CI configuration files for the serverless-operator, which are data files not compiled into binaries.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies CI operator configuration files only, not Ginkgo e2e test source code. No test definitions or IPv4/connectivity assumptions found.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-knative/serverless-operator/OWNERS [maschmid]
• ci-operator/jobs/openshift-knative/serverless-operator/OWNERS [maschmid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@maschmid: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-knative-serverless-operator-main-420-images	openshift-knative/serverless-operator	presubmit	Presubmit changed
pull-ci-openshift-knative-serverless-operator-main-420-kitchensink-upgrade	openshift-knative/serverless-operator	presubmit	Presubmit changed
periodic-ci-openshift-knative-serverless-operator-main-420-kitchensink-upgrade-c	N/A	periodic	Periodic changed
periodic-ci-openshift-knative-serverless-operator-main-421-kitchensink-e2e-c	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[maschmid]

/pj-rehearse pull-ci-openshift-knative-serverless-operator-main-420-kitchensink-upgrade

[openshift-merge-bot]

@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@maschmid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.