OCPBUGS-84961: add kubernetes/conformance umbrella suite#2682
Conversation
|
@not-stbenjam: This pull request references Jira Issue OCPBUGS-84961, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@not-stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Hi @not-stbenjam. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA new global test suite ChangesTest Suite Hierarchy
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@not-stbenjam: This pull request references Jira Issue OCPBUGS-84961, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8697994 to
df7eb4f
Compare
|
@not-stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@not-stbenjam: This pull request references Jira Issue OCPBUGS-84961, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
df7eb4f to
2d10768
Compare
|
@not-stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
2d10768 to
6bd0373
Compare
|
@not-stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@not-stbenjam: This pull request references Jira Issue OCPBUGS-84961, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add a kubernetes/conformance suite that aggregates tests from kubernetes/conformance/parallel and kubernetes/conformance/serial, enabling `openshift-tests run kubernetes/conformance` to run all kubernetes conformance tests in a single invocation. Uses AddGlobalSuite (not AddSuite) so the umbrella starts with zero qualifiers and inherits exclusively from its children via the mergeParentQualifiers fixed-point loop in origin. AddSuite would prepend a catch-all source qualifier that bypasses the exclusion filters ([Disabled:], [Disruptive], [Slow], etc.) in the child qualifiers. Companion to openshift/origin#31261 which adds the Parents field and mergeParentQualifiers mechanism. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6bd0373 to
59c831f
Compare
|
@not-stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/ok-to-test |
|
@not-stbenjam: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@not-stbenjam: This pull request references Jira Issue OCPBUGS-84961, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
|
@not-stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@stbenjam: This PR was included in a payload test run from openshift/origin#31261
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ed3eb40-6332-11f1-8ab2-4fc4f1f8da1c-0 |
|
@mtulio: This PR was included in a payload test run from openshift/origin#31261
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5a4ced0-634b-11f1-9ed7-dc3932a75ec7-0 |
|
/remove-label backports/unvalidated-commits |
|
/cherry-pick release-4.22 release-4.21 |
|
@stbenjam: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, not-stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Installed 5.0 cluster with release image [A] which contain both PR fixes #2682 & kubernetes#31261 10-openshift-kube-conformance getting listed with 3806 and 20-openshift-conformance-validated 4109. Test is still going on. |
|
/verified by CI and @bshaw |
|
@stbenjam: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d8d517e
into
openshift:master
|
@not-stbenjam: Jira Issue OCPBUGS-84961: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-84961 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stbenjam: new pull request created: #2686 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Do we expect the umbrella suite |
|
For kubernetes/conformance: the suite lists 3806 specs total, of which 1408 actually ran (1404 pass / 4 fail) and 2403 were skipped. Previously OPCT saw ~419 tests for kube-conformance. @stbenjam OPCT report can be found here |
|
Fix included in release 5.0.0-0.nightly-2026-06-25-122140 |
…rella suite Backport the kubernetes/conformance suite with Conformance label filter from master (PRs openshift#2682 and openshift#2694 combined). The suite provides the minimal true upstream Kubernetes conformance tests used by OPCT for VCSP validations. Without this fix, running openshift-tests run kubernetes/conformance on 4.22 returns 'suite not found'. With this fix, the suite correctly selects only [Conformance]-labeled tests (~428 tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rella suite Backport the kubernetes/conformance suite with Conformance label filter from master (PRs openshift#2682 and openshift#2694 combined). The suite provides the minimal true upstream Kubernetes conformance tests used by OPCT for VCSP validations. Without this fix, running openshift-tests run kubernetes/conformance on 4.22 returns 'suite not found'. With this fix, the suite correctly selects only [Conformance]-labeled tests (~428 tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Restores the
kubernetes/conformancesuite, which was previously removed. This is an umbrella suite that aggregateskubernetes/conformance/parallelandkubernetes/conformance/serial.Uses
AddGlobalSuiteso the umbrella inherits qualifiers exclusively from its children viamergeParentQualifiers(openshift/origin#31261), rather than picking up a defaultsource == "openshift:payload:hyperkube"qualifier that would match all hyperkube tests.Companion PR
openshift/origin#31261
Test plan
openshift-tests run kubernetes/conformance --dry-runlists the expected testskubernetes/conformance/parallel+kubernetes/conformance/serial[Disabled:],[Disruptive],[Slow]) are not included🤖 Generated with Claude Code
Summary by CodeRabbit