Skip to content

NO-JIRA: image-references should reference aws-karpenter-provider-aws#7

Open
maxcao13 wants to merge 1 commit intoopenshift:mainfrom
maxcao13:fix-image-references
Open

NO-JIRA: image-references should reference aws-karpenter-provider-aws#7
maxcao13 wants to merge 1 commit intoopenshift:mainfrom
maxcao13:fix-image-references

Conversation

@maxcao13
Copy link
Copy Markdown
Member

@maxcao13 maxcao13 commented May 7, 2026

The image references should reference the actual karpenter image in the payload.

We're enable to promote a built release payload image including the karpenter-operator because one of the image-references didn't exist: openshift/release#79001. It should reference aws-karpenter-provider-aws which actually does exist in the payload.

Summary by CodeRabbit

  • Chores
    • Updated image stream references to include the AWS Karpenter provider image and removed the legacy Karpenter image reference.

The image references should reference the actual karpenter image in the payload.

Signed-off-by: Max Cao <macao@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@maxcao13: This pull request explicitly references no jira issue.

Details

In response to this:

The image references should reference the actual karpenter image in the payload.

We're enable to promote a built release payload image including the karpenter-operator because one of the image-references didn't exist: openshift/release#79001. It should reference aws-karpenter-provider-aws which actually does exist in the payload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jkyros and joelsmith May 7, 2026 19:33
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c9bb422a-94a1-4dcc-9103-49065e273d69

📥 Commits

Reviewing files that changed from the base of the PR and between 29bf971 and e37b70d.

📒 Files selected for processing (1)
  • install/image-references

Walkthrough

The install/image-references OpenShift ImageStream configuration is updated to replace the karpenter image tag with a new aws-karpenter-provider-aws tag. The new tag references quay.io/openshift/origin-aws-karpenter-provider-aws:latest, while the existing karpenter-operator tag remains unchanged.

Changes

ImageStream Tag Update

Layer / File(s) Summary
Configuration
install/image-references
The karpenter tag (pointing to quay.io/openshift/origin-karpenter:latest) is removed and replaced with a new aws-karpenter-provider-aws tag (pointing to quay.io/openshift/origin-aws-karpenter-provider-aws:latest). The karpenter-operator tag remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating image-references to reference the aws-karpenter-provider-aws image, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not contain any Ginkgo tests. Changes are limited to image-references configuration file only. Custom check is not applicable.
Test Structure And Quality ✅ Passed The PR modifies image-references manifest, not test code. Custom check for Ginkgo test quality is not applicable to configuration file changes. No Ginkgo tests are affected.
Microshift Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests. It only updates install/image-references (a YAML file) and includes pre-existing unit tests. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies image references in an OpenShift ImageStream manifest. No new Ginkgo e2e tests are added. The SNO Test Compatibility check applies only to newly added test code.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only updates image references in an ImageStream metadata file. It introduces no deployment manifests, controllers, or scheduling constraints that would affect topology compatibility.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check is not applicable to this PR, which only modifies a YAML ImageStream configuration file. No Go code, test binaries, or stdout-writing processes are affected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to configuration files (ImageStream manifest, Makefile, Dockerfile, deployment manifests, etc.). The custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxcao13
Copy link
Copy Markdown
Member Author

maxcao13 commented May 7, 2026

/test e2e-aws

seems like a infra flake, we aren't even including the image in the payload yet.
also this is an unrelated image/operator: quay.io/openshift/ci:ocp_5.0_vcf-migration-operator

@maxcao13
Copy link
Copy Markdown
Member Author

maxcao13 commented May 7, 2026

/test e2e-aws

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

@maxcao13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws e37b70d link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxcao13
Copy link
Copy Markdown
Member Author

maxcao13 commented May 8, 2026

/test e2e-aws

@elmiko
Copy link
Copy Markdown

elmiko commented May 8, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants