Re-Add replaces field to CSV and update Makefile to preserve it - #1045
Closed
yuumasato wants to merge 1 commit into
Closed
Re-Add replaces field to CSV and update Makefile to preserve it#1045yuumasato wants to merge 1 commit into
yuumasato wants to merge 1 commit into
Conversation
The update-skip-range Makefile target was removing the replaces field from the base CSV. Replace the deletion with a conditional update that automatically sets replaces to the previous version when VERSION changes, and leaves it untouched otherwise. Also update the base CSV version during bundle generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
The Makefile changes have been incorporated into #1038 for |
Contributor
Author
|
Sorry, as pointed out by Vincent, downstream's manifest is updated by so the replaces key should be there in the current 1.4.1 build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update-skip-range Makefile target was removing the replaces field from the base CSV.
Replace the deletion with a conditional update that automatically sets replaces to the previous version when VERSION changes, and leaves it untouched otherwise.
Also update the base CSV version during bundle generation.