Updating Dockerfile.rhel10 base image from base-rhel9 to base-rhel10.#195
Updating Dockerfile.rhel10 base image from base-rhel9 to base-rhel10.#195ybettan wants to merge 1 commit into
Conversation
The base-rhel10 image is now available in the CI registry (registry.ci.openshift.org/ocp/5.0:base-rhel10), so we can use the proper RHEL 10 base image for the DTK-10 build. Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
Walkthrough
ChangesDocker base image update
🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile.rhel10`:
- Line 1: The final image is missing an explicit non-root user declaration, so
it inherits the base image default and is flagged as running as root. Update the
Dockerfile by adding a non-root USER instruction after the last metadata-writing
RUN step, ensuring the final runtime identity is non-root. Use the existing
Dockerfile final stage context and preserve DTK runtime permissions while
switching the final user.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a26cbf00-3022-49b3-b115-7f4075535425
📒 Files selected for processing (1)
Dockerfile.rhel10
|
/lgtm |
1 similar comment
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman, ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@ybettan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified bypass |
|
@yevgeny-shnaidman: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The base-rhel10 image is now available in the CI registry (registry.ci.openshift.org/ocp/5.0:base-rhel10),
so we can use the proper RHEL 10 base image for the DTK-10 build.
/assign @yevgeny-shnaidman @TomerNewman
Summary by CodeRabbit