Skip to content

[release-4.22] OCPBUGS-84963: Add bottom pagination to ConsoleDataView for mobile responsiveness#16394

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-16391-to-release-4.22
May 4, 2026
Merged

[release-4.22] OCPBUGS-84963: Add bottom pagination to ConsoleDataView for mobile responsiveness#16394
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-16391-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 4, 2026

This is an automated cherry-pick of #16391

/assign rhamilto

/cherrypick release-4.21

@rhamilto @claude
OCPBUGS-84876: Add bottom pagination to ConsoleDataView for mobile re…
96ae118 
…sponsiveness

The ConsoleDataView component was missing bottom pagination, which is
required by PatternFly design guidelines for proper mobile responsiveness.
On mobile viewports, the top pagination condenses to just an item count,
so full pagination controls must be available in the footer/bottom.

This change adds a Pagination component with variant="bottom" after the
DataViewTable to ensure pagination controls remain accessible on all
viewport sizes.

Additionally, adds complete i18n support to both top and bottom pagination
components with proper aria-labels for navigation buttons (first, previous,
next, last pages) and translated visible text (ofWord, itemsPerPage,
perPageSuffix) to ensure full accessibility and internationalization.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 4, 2026
Merged
3 tasks
@openshift-ci openshift-ci Bot requested review from TheRealJon and jhadvig May 4, 2026 18:43
@openshift-ci openshift-ci Bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 4, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-84876 has been cloned as Jira Issue OCPBUGS-84963. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-84963: Add bottom pagination to ConsoleDataView for mobile responsiveness

Details

In response to this:

This is an automated cherry-pick of #16391

/assign rhamilto

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-84876: Add bottom pagination to ConsoleDataView for mobile responsiveness [release-4.22] OCPBUGS-84963: Add bottom pagination to ConsoleDataView for mobile responsiveness May 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 4, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84963, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-84876 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-84876 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16391

/assign rhamilto

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Copy Markdown
Member

rhamilto commented May 4, 2026

/approve
/lgtm
/label backport-risk-assessed
/verified by @rhamilto

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 4, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 4, 2026

@rhamilto: This PR has been marked as verified by @rhamilto.

Details

In response to this:

/approve
/lgtm
/label backport-risk-assessed
/verified by @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 4, 2026

/retest-required

Remaining retests: 0 against base HEAD a783cdc and 2 for PR HEAD 96ae118 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f6de0e7 into openshift:release-4.22 May 4, 2026
7 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 4, 2026

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84963
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84963 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #16391

/assign rhamilto

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

openshift-cherrypick-robot commented May 4, 2026

@openshift-cherrypick-robot: #16394 failed to apply on top of branch "release-4.21":

Applying: OCPBUGS-84876: Add bottom pagination to ConsoleDataView for mobile responsiveness
Using index info to reconstruct a base tree...
M	frontend/packages/console-app/src/components/data-view/ConsoleDataView.tsx
M	frontend/public/locales/en/public.json
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/locales/en/public.json
Auto-merging frontend/packages/console-app/src/components/data-view/ConsoleDataView.tsx
CONFLICT (content): Merge conflict in frontend/packages/console-app/src/components/data-view/ConsoleDataView.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-84876: Add bottom pagination to ConsoleDataView for mobile responsiveness
Details

In response to this:

This is an automated cherry-pick of #16391

/assign rhamilto

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 4, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

@sanketpathak sanketpathak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @rhamilto @sanketpathak