OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384
OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384cajieh wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
component/core
|
/jira refresh |
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test backend |
cajieh
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThis pull request refactors vSphere plugin error messaging by migrating error-related locale entries from the global 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/packages/vsphere-plugin/locales/es/vsphere-plugin.json`:
- Line 16: The Spanish translation for the key "Failed to persist {{secret}}" is
incorrect (it reads “No se pudo analizar {{secret}}” meaning "analyze"); update
the value in vsphere-plugin.json to accurately convey persistence failure, e.g.
"No se pudo guardar {{secret}}" or "No se pudo persistir {{secret}}", ensuring
the placeholder {{secret}} remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 24a73580-dece-4bb7-8c96-21489617bfd6
📒 Files selected for processing (14)
frontend/packages/vsphere-plugin/locales/en/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/locales/es/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/locales/fr/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/locales/ja/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/locales/ko/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/locales/zh/vsphere-plugin.jsonfrontend/packages/vsphere-plugin/src/components/persist.tsfrontend/packages/vsphere-plugin/src/components/utils.tsfrontend/public/locales/en/public.jsonfrontend/public/locales/es/public.jsonfrontend/public/locales/fr/public.jsonfrontend/public/locales/ja/public.jsonfrontend/public/locales/ko/public.jsonfrontend/public/locales/zh/public.json
📜 Review details
🔇 Additional comments (13)
frontend/packages/vsphere-plugin/locales/zh/vsphere-plugin.json (1)
13-21: Plugin-scoped zh locale keys are restored correctlyThe added keys align with the vSphere error paths and keep interpolation placeholders intact.
frontend/packages/vsphere-plugin/locales/ko/vsphere-plugin.json (1)
13-21: Korean locale additions are consistent with plugin error key coverageNice update restoring the missing plugin-owned error strings and preserving placeholders.
frontend/packages/vsphere-plugin/locales/en/vsphere-plugin.json (1)
13-21: English source locale now has the missing plugin error stringsThis restores the expected key set (including
Unexpected error) for the vSphere plugin namespace.frontend/packages/vsphere-plugin/locales/ja/vsphere-plugin.json (1)
13-21: Japanese plugin error key set is now completeThe added keys match the expected vSphere plugin failures and keep interpolation tokens correctly.
frontend/packages/vsphere-plugin/locales/fr/vsphere-plugin.json (1)
10-10: French locale updates look consistent with plugin error handlingGood to see the missing plugin keys restored with placeholders preserved.
Also applies to: 13-21
frontend/public/locales/es/public.json (1)
1809-1809: Public Spanish locale tail update is cleanThis keeps
public.jsonconsistent with the plugin-key migration.frontend/public/locales/en/public.json (1)
1811-1811: Public English locale update is consistent with namespace cleanupNo issues in this segment.
frontend/public/locales/fr/public.json (1)
1809-1809: Looks good — locale file remains consistent after cleanup.Keeping
"Enabled": "Activé"as the final entry is valid and aligns with the locale-key consolidation pattern in this PR.frontend/public/locales/ko/public.json (1)
1809-1809: LGTM — Korean locale end-of-file key is correct.
"Enabled": "활성화됨"is correctly retained and the JSON ending is clean.frontend/public/locales/ja/public.json (1)
1809-1810: Scoped locale cleanup looks correct.Ending
public.jsonwith"Enabled"after removing vSphere-specific error keys is consistent with the plugin-scoped i18n migration.frontend/packages/vsphere-plugin/src/components/utils.ts (1)
36-36: Fallback i18n key now correctly namespaced.Using
vsphere-plugin~Unexpected errorhere aligns runtime fallback messaging with plugin locale ownership.frontend/packages/vsphere-plugin/src/components/persist.ts (1)
101-104: Error key migration is consistent across all PersistError paths.These updates correctly align vSphere persistence failures with plugin-scoped i18n keys while preserving detailed error propagation.
Also applies to: 141-143, 305-313, 575-575, 583-586, 592-595, 602-602, 610-613
frontend/public/locales/zh/public.json (1)
1809-1809: Global locale cleanup is aligned with plugin scoping.Keeping this file’s terminal key as
"Enabled"after removing vSphere-specific errors matches the intended i18n split.
…ocales/en/ Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/IjrLfI0tmESSiOSwai9SQ2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
verified that the locales are moved from public to vsphere /verified by @logonoff |
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cajieh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Analysis / Root cause:
Following recent updates to the vSphere plugin, a regression was identified where several localized strings were removed or omitted from the locales/en/ source directory despite remaining active in the component implementation.
This resulted in:
Broken Translations: Missing keys caused the UI to fallback to raw key names or empty strings in non-English locales.
Sync Mismatch: The Phrase (Memsource) portal lacked these keys, preventing the localization team from providing translations for upcoming releases.
Solution description:
Source Restoration: Re-introduced the missing string keys into frontend/public/locales/en/vsphere-plugin.json to align the locale source with the current code implementation.
Phrase Portal Sync: Will be uploaded to portal later on.
Test setup:
Clean the local environment:
rm -rf node_modules && yarn install && yarn i18nEnsure the vSphere plugin is enabled in your local development environment.
Test cases:
Key Verification: Verify that the "Error loading" and other vSphere-specific messages no longer show raw translation keys in the console or UI.
Locale Switching: Switch the console language to a supported secondary language (e.g., French) and verify that the keys now appear (either as the restored English string or the translated version if already available in the portal).
Build Integrity: Run
yarn buildto ensure that the i18n asset compilation completes without errors.Screenshots
Reviewers and assignees:
Summary by CodeRabbit
New Features
Localization