Skip to content

NO-JIRA: Add approvers and reviewers to helm-plugin OWNERS#16361

Open
sowmya-sl wants to merge 1 commit intoopenshift:mainfrom
sowmya-sl:add-owners-helm
Open

NO-JIRA: Add approvers and reviewers to helm-plugin OWNERS#16361
sowmya-sl wants to merge 1 commit intoopenshift:mainfrom
sowmya-sl:add-owners-helm

Conversation

@sowmya-sl
Copy link
Copy Markdown
Contributor

@sowmya-sl sowmya-sl commented Apr 28, 2026

The helm-plugin OWNERS file only had a component label. Add dedicated approvers and reviewers to ensure helm-plugin changes are reviewed by helm team.

Summary by CodeRabbit

  • Chores
    • Updated the OWNERS file to explicitly define approvers and reviewers for the helm-plugin package, establishing clearer governance and review responsibilities.

The helm-plugin OWNERS file only had a component label. Add dedicated
approvers and reviewers to ensure helm-plugin changes are reviewed by
helm team.
@openshift-ci openshift-ci Bot requested review from jhadvig and stefanonardo April 28, 2026 07:53
@openshift-ci openshift-ci Bot added the component/helm Related to helm-plugin label Apr 28, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

The OWNERS file for the Helm plugin package was updated to define explicit governance structure. Two new sections were added—approvers and reviewers—each specifying four team members responsible for code review and approval decisions. The existing component/helm label remains in place. This change is purely additive, establishing clear ownership and review responsibilities for the Helm plugin module within the frontend packages directory structure.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description explains the rationale but does not follow the required template with sections like Analysis, Solution, Test cases, or Browser conformance. Fill out the required description template with at least Analysis/Root cause and Solution description sections to ensure proper triage and review.
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only modifies the OWNERS file and does not add, modify, or change any Ginkgo test files, making it not applicable to the Stable and Deterministic Test Names check.
Test Structure And Quality ✅ Passed PR modifies only OWNERS config file with no Ginkgo test code present, making the test quality check inapplicable.
Microshift Test Compatibility ✅ Passed PR modifies only OWNERS metadata file without adding any new Ginkgo e2e tests, Go test files, or test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only OWNERS file; no new Ginkgo e2e tests present, so SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only OWNERS file for governance configuration, not workload specifications or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed Pull request modifies only OWNERS governance file in helm-plugin frontend package; zero changes to executable code, Go binaries, or process-level test setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only frontend/packages/helm-plugin/OWNERS file for RBAC configuration; contains no Ginkgo e2e test code.
Title check ✅ Passed The title accurately and concisely describes the main change: adding approvers and reviewers sections to the helm-plugin OWNERS file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

@sowmya-sl: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@sowmya-sl, I think you'll want to add the NO-JIRA prefix to the PR title, and you'll probably need a /verified by....

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sowmya-sl, webbnh
Once this PR has been reviewed and has the lgtm label, please assign logonoff for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sowmya-sl sowmya-sl changed the title Add approvers and reviewers to helm-plugin OWNERS NO-JIRA: Add approvers and reviewers to helm-plugin OWNERS Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sowmya-sl: This pull request explicitly references no jira issue.

Details

In response to this:

The helm-plugin OWNERS file only had a component label. Add dedicated approvers and reviewers to ensure helm-plugin changes are reviewed by helm team.

Summary by CodeRabbit

  • Chores
  • Updated the OWNERS file to explicitly define approvers and reviewers for the helm-plugin package, establishing clearer governance and review responsibilities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2026
@sowmya-sl
Copy link
Copy Markdown
Contributor Author

/verified by @sowmya-sl

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sowmya-sl: This PR has been marked as verified by @sowmya-sl.

Details

In response to this:

/verified by @sowmya-sl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@webbnh
Copy link
Copy Markdown
Contributor

webbnh commented Apr 29, 2026

/assign logonoff

@logonoff
Copy link
Copy Markdown
Member

/label px-approved
/label docs-approved
/assign @jhadvig

@openshift-ci openshift-ci Bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/helm Related to helm-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants