Skip to content

[release-4.18] OCPBUGS-84479: Fix VolumeSnapshot and VolumeSnapshotContent table sorting#16349

Open
stefanonardo wants to merge 1 commit intoopenshift:release-4.18from
stefanonardo:OCPBUGS-84479
Open

[release-4.18] OCPBUGS-84479: Fix VolumeSnapshot and VolumeSnapshotContent table sorting#16349
stefanonardo wants to merge 1 commit intoopenshift:release-4.18from
stefanonardo:OCPBUGS-84479

Conversation

@stefanonardo
Copy link
Copy Markdown
Contributor

@stefanonardo stefanonardo commented Apr 27, 2026

Cherry-pick of #16335.

Test plan

  • Navigate to Storage → VolumeSnapshots in the OpenShift console
  • Create test snapshots with different sizes and statuses
  • Click Status column header and verify snapshots sort alphabetically by status
  • Click Size column header and verify snapshots sort numerically by size (ascending/descending)
  • Click Source column header and verify snapshots sort alphabetically by source PVC name
  • Navigate to VolumeSnapshotContents tab and verify Status and Size sorting works

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a52e5c10-a133-410f-90d7-7691321d9c02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from rawagner and spadgett April 27, 2026 09:13
@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Apr 27, 2026
@stefanonardo stefanonardo changed the title Fix VolumeSnapshot and VolumeSnapshotContent table sorting [release-4.18] Fix VolumeSnapshot and VolumeSnapshotContent table sorting Apr 27, 2026
@cajieh
Copy link
Copy Markdown
Contributor

cajieh commented Apr 27, 2026

Screenshot 2026-04-27 at 11 23 24 AM Screenshot 2026-04-27 at 11 23 30 AM

/lgtm
/verified by @cajieh
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 27, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cajieh: This PR has been marked as verified by @cajieh.

Details

In response to this:

Screenshot 2026-04-27 at 11 23 24 AM Screenshot 2026-04-27 at 11 23 30 AM

/lgtm
/verified by @cajieh
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, stefanonardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2026
@cajieh
Copy link
Copy Markdown
Contributor

cajieh commented Apr 27, 2026

/test e2e-gcp-console

@stefanonardo
Copy link
Copy Markdown
Contributor Author

/retest

3 similar comments
@stefanonardo
Copy link
Copy Markdown
Contributor Author

/retest

@stefanonardo
Copy link
Copy Markdown
Contributor Author

/retest

@stefanonardo
Copy link
Copy Markdown
Contributor Author

/retest

@stefanonardo stefanonardo changed the title [release-4.18] Fix VolumeSnapshot and VolumeSnapshotContent table sorting [release-4.18] OCPBUGS-84479: Fix VolumeSnapshot and VolumeSnapshotContent table sorting Apr 30, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stefanonardo: This pull request references Jira Issue OCPBUGS-84479, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-84271 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-84271 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry-pick of #16335.

Test plan

  • Navigate to Storage → VolumeSnapshots in the OpenShift console
  • Create test snapshots with different sizes and statuses
  • Click Status column header and verify snapshots sort alphabetically by status
  • Click Size column header and verify snapshots sort numerically by size (ascending/descending)
  • Click Source column header and verify snapshots sort alphabetically by source PVC name
  • Navigate to VolumeSnapshotContents tab and verify Status and Size sorting works

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stefanonardo: This pull request references Jira Issue OCPBUGS-84479, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-84271 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-84271 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD dda5808 and 2 for PR HEAD b468244 in total

@cajieh
Copy link
Copy Markdown
Contributor

cajieh commented May 2, 2026

/test e2e-gcp-console

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 2, 2026

@stefanonardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console b468244 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants