[release-4.18] OCPBUGS-80238: Bump google.golang.org/grpc to v1.79.3#1502
Conversation
|
@ocp-sustaining-admins: This pull request references Jira Issue OCPBUGS-80238, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoBump gRPC and dependencies for security updates
WalkthroughsDescription• Bump google.golang.org/grpc to v1.70.0 with security patch • Update OpenTelemetry dependencies to v1.34.0 • Update golang.org/x dependencies for security fixes • Add new OpenTelemetry auto/sdk dependency Diagramflowchart LR
grpc["google.golang.org/grpc v1.65.0"] -- "security patch" --> grpc_new["v1.70.0 via openshift-sustaining"]
otel["OpenTelemetry deps v1.28.0"] -- "version bump" --> otel_new["v1.34.0"]
golang["golang.org/x/* deps"] -- "security updates" --> golang_new["crypto v0.32.0, net v0.34.0, etc."]
grpc_new --> replace["Replace directive added"]
File Changes1. go.mod
|
Code Review by Qodo
1. gRPC version mismatch
|
|
Hi @ocp-sustaining-admins. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ocp-sustaining-admins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| github.com/jaypipes/ghw => github.com/jaypipes/ghw v0.8.1-0.20210605191321-eb162add542b | ||
| ) | ||
|
|
||
| replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.71.3-sec.1 |
There was a problem hiding this comment.
1. Grpc version mismatch 🐞 Bug ≡ Correctness
The PR title says gRPC is bumped to v1.79.3, but go.mod replaces google.golang.org/grpc with github.com/openshift-sustaining/grpc-go v1.71.3-sec.1 and the vendored grpc code reports Version="1.71.3". As a result, this PR does not actually deliver a v1.79.3 upgrade.
Agent Prompt
### Issue description
The PR claims a gRPC upgrade to v1.79.3, but the code changes pin gRPC to 1.71.3 (via a replace to `github.com/openshift-sustaining/grpc-go v1.71.3-sec.1`).
### Issue Context
This is a release/security-motivated dependency bump PR; the effective dependency version must match the intended target, or the PR title/description must be corrected to avoid shipping the wrong change.
### Fix Focus Areas
- go.mod[176-181]
- go.mod[241-249]
- go.sum[1349-1350]
### What to change
- Either (A) update the `replace google.golang.org/grpc => ...` target to the intended v1.79.3 (or the sustaining fork equivalent for 1.79.3, if that is the policy), and run `go mod tidy` + `go mod vendor`.
- Or (B) if 1.71.3-sec.1 is the intended final state, update the PR title/description to reflect the actual gRPC version being introduced, and ensure any tracking ticket expectation is aligned.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This is an automated PR from the ARC system.
Go version used:
go1.22.12Patch applied:
github.com/openshift-sustaining/grpc-go@v1.71.3-sec.1Modules affected:
.The commands used to generate this PR were:
A member of the Red Hat Openshift Sustaining Team will review the PR and take appropriate action.