Skip to content

LOG-7348: Add CLO logic for GCP Workload Identity Federation#3259

Open
Clee2691 wants to merge 2 commits intoopenshift:masterfrom
Clee2691:LOG-7348-gcp-wif-support
Open

LOG-7348: Add CLO logic for GCP Workload Identity Federation#3259
Clee2691 wants to merge 2 commits intoopenshift:masterfrom
Clee2691:LOG-7348-gcp-wif-support

Conversation

@Clee2691
Copy link
Copy Markdown
Contributor

@Clee2691 Clee2691 commented Apr 24, 2026

Description

This PR supersedes #3243.

The GCP output has been updated to align with our other cloud offerings by introducing a type for either serviceAccount (static) or workloadIdentity (short lived token) credentials.

The token source for WIF can either be from the CLF's service account or from a secret.

This PR also introduces validation of the credentials file.

/cc @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2026

@Clee2691: This pull request references LOG-7348 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR supersedes #3243.

Original Description:

Simple CLO changes to allow googeCloud WIF authentication. WIF functionality will also require an update to the vector client. The CLO changes are backwards compatible with existing vector auth functionality.

I've included a design document to highlight the API decision. There are no changes to the googleCloud authentication API. Service account tokens are always projected for GCP outputs to support WIF. This does not present any performance or security issues and greatly simplifies the implementation.

Users provide an authentication secret reference pointing to a credentials file:

type: "service_account" (current static authentication)
OR
type: "external_account" (Workload Identity Federation)

Vector detects the type of file and handles the appropriate authentication flow.

/cc @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Comment thread docs/features/logforwarding/outputs/googlecloud/gcp-authentication-design.adoc Outdated
Comment thread docs/features/logforwarding/outputs/googlecloud/gcp-authentication-design.adoc Outdated
Comment thread docs/features/logforwarding/outputs/googlecloud/gcp-authentication-design.adoc Outdated
Comment thread docs/features/logforwarding/outputs/googlecloud/gcp-authentication-design.adoc Outdated
@Clee2691 Clee2691 force-pushed the LOG-7348-gcp-wif-support branch 2 times, most recently from a15dd94 to 3952e55 Compare April 29, 2026 20:32
@jcantrill
Copy link
Copy Markdown
Contributor

/approve

@jcantrill
Copy link
Copy Markdown
Contributor

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@Clee2691 Clee2691 force-pushed the LOG-7348-gcp-wif-support branch from 3952e55 to 15467b1 Compare April 30, 2026 15:48
Comment thread api/observability/v1/output_types.go Outdated
@jcantrill
Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2026
Comment thread api/observability/v1/output_types.go Outdated
@Clee2691 Clee2691 force-pushed the LOG-7348-gcp-wif-support branch from 15467b1 to 309cc7e Compare April 30, 2026 19:39
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@Clee2691 Clee2691 force-pushed the LOG-7348-gcp-wif-support branch from 309cc7e to ee0f947 Compare April 30, 2026 22:20
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. release/6.6 tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants