Skip to content

OBSDA-1243: Add test to verify forwarding to Elasticsearch 9#3258

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jcantrill:obsda1243
Apr 29, 2026
Merged

OBSDA-1243: Add test to verify forwarding to Elasticsearch 9#3258
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jcantrill:obsda1243

Conversation

@jcantrill
Copy link
Copy Markdown
Contributor

@jcantrill jcantrill commented Apr 24, 2026

Description

This PR:

  • Adds a functional test of existing functionality to forward to Elasticsearch v9
  • Updates API comments to clarify ES.Version represents the ES API version
  • Updates documents to clarify ES.Version as ES API Version

Links

cc @simonkrenger @vparfonov @Clee2691

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2026 •
edited by openshift-ci Bot
Loading

@jcantrill: This pull request references OBSDA-1243 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR:

  • Adds a functional test of existing functionality to forward to Elasticsearch v9
  • Updates API comments to clarify ES.Version represents the ES API version
  • Updates documents to clarify ES.Version as ES API Version

Links

cc @simonkrenger @vparfonov @Clee2691

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2026
@openshift-ci openshift-ci Bot requested review from alanconway and vparfonov April 24, 2026 14:46
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
vparfonov
vparfonov reviewed Apr 24, 2026
View reviewed changes
Comment thread test/functional/outputs/elasticsearch/forward_to_elasticsearch_test.go Outdated
outputTestLog := logs[0]
outputLogTemplate.ViaqIndexName = ""
Expect(outputTestLog).To(matchers.FitLogFormatTemplate(outputLogTemplate))
Fail("")
Copy link
Copy Markdown
Contributor

@vparfonov vparfonov Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected?

@jcantrill
Copy link
Copy Markdown
Contributor Author

jcantrill commented Apr 27, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2026
@jcantrill
Copy link
Copy Markdown
Contributor Author

jcantrill commented Apr 28, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2026
@vparfonov
Copy link
Copy Markdown
Contributor

vparfonov commented Apr 28, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented Apr 28, 2026

/retest-required

Remaining retests: 0 against base HEAD bdeb113 and 2 for PR HEAD f746151 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 1fe4a19 into openshift:master Apr 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanconway alanconway Awaiting requested review from alanconway

1 more reviewer

@vparfonov vparfonov vparfonov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vparfonov vparfonov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcantrill @openshift-ci-robot @vparfonov