WIP: [release-4.22] SPLAT-2865: Migrate vSphere sync of kube-cloud-config to 3CMO- #481 - #498
WIP: [release-4.22] SPLAT-2865: Migrate vSphere sync of kube-cloud-config to 3CMO- #481#498vr4manta wants to merge 6 commits into
Conversation
|
@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vr4manta The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@vr4manta: This PR was included in a payload test run from openshift/api#2969 |
|
@vr4manta: This PR was included in a payload test run from openshift/api#2969
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d51e210-a858-11f1-8021-2ae6565127f3-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/api#2969
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb9027b0-a873-11f1-9d70-57471176ae00-0 |
SPLAT-2865
Changes
This PR adds logic to the KubeCloudConfigController to conditionally skip managing the kube-cloud-config ConfigMap based on platform-specific feature gates. Specifically, for vSphere platforms, when the VSphereMultiVCenterDay2 feature gate is enabled, ownership of the ConfigMap transfers to the cluster-cloud-controller-manager-operator.
Notes
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:
Since the original PRs require changes to API and library-go, we need to make sure to update the references here to point to the release-4.22 variants to make sure we do not pull in new functionality.