Skip to content

Remove tools extracted to ci-tools-standalone#5146

Open
jmguzik wants to merge 1 commit intoopenshift:mainfrom
jmguzik:remove-tools
Open

Remove tools extracted to ci-tools-standalone#5146
jmguzik wants to merge 1 commit intoopenshift:mainfrom
jmguzik:remove-tools

Conversation

@jmguzik
Copy link
Copy Markdown
Contributor

@jmguzik jmguzik commented Apr 30, 2026

The following tools have been moved to the ci-tools-standalone repository and are removed from this codebase:

  • backport-verifier
  • ci-scheduling-webhook
  • determinize-peribolos
  • gpu-scheduling-webhook
  • helpdesk-faq
  • pipeline-controller
  • pr-reminder
  • publicize
  • retester

This also removes:

  • images/ Dockerfiles for all tools above (except retester which had none)
  • pkg/retester which was exclusively used by cmd/retester

pkg/helpdesk-faq is retained as it is still used by pkg/slack/events/helpdesk.

Made-with: Cursor

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed nine deprecated services: backport-verifier, ci-scheduling-webhook, determinize-peribolos, gpu-scheduling-webhook, helpdesk-faq, pipeline-controller, pr-reminder, publicize, and retester.
    • Removed associated container images, test suites, and documentation for the removed services.

The following tools have been moved to the ci-tools-standalone
repository and are removed from this codebase:

- backport-verifier
- ci-scheduling-webhook
- determinize-peribolos
- gpu-scheduling-webhook
- helpdesk-faq
- pipeline-controller
- pr-reminder
- publicize
- retester

This also removes:
- images/ Dockerfiles for all tools above (except retester which had none)
- pkg/retester which was exclusively used by cmd/retester

pkg/helpdesk-faq is retained as it is still used by pkg/slack/events/helpdesk.

Signed-off-by: Jakub Guzik <jguzik@redhat.com>
Made-with: Cursor
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 190f4659-94c0-4289-95a5-a8dad62658af

📥 Commits

Reviewing files that changed from the base of the PR and between dbe2e97 and eadf7aa.

📒 Files selected for processing (59)
  • cmd/backport-verifier/main.go
  • cmd/backport-verifier/server.go
  • cmd/backport-verifier/server_test.go
  • cmd/ci-scheduling-webhook/main.go
  • cmd/ci-scheduling-webhook/monitoring/failed-pods.sh
  • cmd/ci-scheduling-webhook/monitoring/problem-pods.sh
  • cmd/ci-scheduling-webhook/mutation.go
  • cmd/ci-scheduling-webhook/prioritization.go
  • cmd/ci-scheduling-webhook/readme.md
  • cmd/determinize-peribolos/main.go
  • cmd/gpu-scheduling-webhook/README.md
  • cmd/gpu-scheduling-webhook/main.go
  • cmd/gpu-scheduling-webhook/main_test.go
  • cmd/helpdesk-faq/main.go
  • cmd/pipeline-controller/config_data_provider.go
  • cmd/pipeline-controller/config_data_provider_test.go
  • cmd/pipeline-controller/config_watcher.go
  • cmd/pipeline-controller/config_watcher_test.go
  • cmd/pipeline-controller/helpers.go
  • cmd/pipeline-controller/helpers_test.go
  • cmd/pipeline-controller/main.go
  • cmd/pipeline-controller/main_test.go
  • cmd/pipeline-controller/pipeline_auto_cache.go
  • cmd/pipeline-controller/pipeline_context_test.go
  • cmd/pipeline-controller/reconciler.go
  • cmd/pipeline-controller/reconciler_test.go
  • cmd/pr-reminder/README.md
  • cmd/pr-reminder/main.go
  • cmd/pr-reminder/main_test.go
  • cmd/publicize/README.md
  • cmd/publicize/main.go
  • cmd/publicize/server.go
  • cmd/publicize/server_test.go
  • cmd/retester/main.go
  • cmd/retester/main_test.go
  • images/backport-verifier/Dockerfile
  • images/ci-scheduling-webhook/Dockerfile
  • images/determinize-peribolos/Dockerfile
  • images/gpu-scheduling-webhook/Dockerfile
  • images/helpdesk-faq/Dockerfile
  • images/pipeline-controller/Dockerfile
  • images/pr-reminder/Dockerfile
  • images/publicize/Dockerfile
  • pkg/retester/cache.go
  • pkg/retester/fileBackOffCache.go
  • pkg/retester/retester.go
  • pkg/retester/retester_test.go
  • pkg/retester/s3BackOffCache.go
  • pkg/retester/testdata/NewController/basic_case.yaml
  • pkg/retester/testdata/jobconfig/simple.yaml
  • pkg/retester/testdata/loadFromDiskNow/basic_case.yaml
  • pkg/retester/testdata/loadFromDiskNow/wrong_format.yaml
  • pkg/retester/testdata/prowconfig/simple.yaml
  • pkg/retester/testdata/testconfig/config.yaml
  • pkg/retester/testdata/testconfig/default.yaml
  • pkg/retester/testdata/testconfig/empty.yaml
  • pkg/retester/testdata/testconfig/no-config.yaml
  • pkg/retester/testdata/testconfig/openshift-config.yaml
  • pkg/retester/testdata/testconfig/wrong_format.yaml
💤 Files with no reviewable changes (59)
  • cmd/ci-scheduling-webhook/monitoring/problem-pods.sh
  • pkg/retester/testdata/testconfig/wrong_format.yaml
  • pkg/retester/testdata/testconfig/empty.yaml
  • pkg/retester/testdata/prowconfig/simple.yaml
  • pkg/retester/testdata/loadFromDiskNow/wrong_format.yaml
  • images/pr-reminder/Dockerfile
  • images/backport-verifier/Dockerfile
  • cmd/publicize/README.md
  • pkg/retester/testdata/testconfig/no-config.yaml
  • images/helpdesk-faq/Dockerfile
  • pkg/retester/testdata/loadFromDiskNow/basic_case.yaml
  • pkg/retester/testdata/jobconfig/simple.yaml
  • images/ci-scheduling-webhook/Dockerfile
  • pkg/retester/testdata/NewController/basic_case.yaml
  • pkg/retester/testdata/testconfig/config.yaml
  • cmd/pipeline-controller/config_watcher_test.go
  • cmd/ci-scheduling-webhook/readme.md
  • cmd/gpu-scheduling-webhook/main_test.go
  • cmd/gpu-scheduling-webhook/main.go
  • cmd/pipeline-controller/config_watcher.go
  • images/determinize-peribolos/Dockerfile
  • cmd/ci-scheduling-webhook/monitoring/failed-pods.sh
  • cmd/backport-verifier/main.go
  • images/gpu-scheduling-webhook/Dockerfile
  • cmd/backport-verifier/server.go
  • cmd/publicize/main.go
  • pkg/retester/s3BackOffCache.go
  • pkg/retester/cache.go
  • cmd/retester/main.go
  • pkg/retester/testdata/testconfig/openshift-config.yaml
  • images/pipeline-controller/Dockerfile
  • pkg/retester/fileBackOffCache.go
  • cmd/gpu-scheduling-webhook/README.md
  • cmd/publicize/server_test.go
  • cmd/pipeline-controller/pipeline_auto_cache.go
  • cmd/pr-reminder/main.go
  • cmd/helpdesk-faq/main.go
  • cmd/publicize/server.go
  • cmd/ci-scheduling-webhook/main.go
  • cmd/pipeline-controller/helpers.go
  • cmd/pipeline-controller/reconciler.go
  • pkg/retester/retester.go
  • cmd/retester/main_test.go
  • cmd/pipeline-controller/main.go
  • cmd/pipeline-controller/config_data_provider_test.go
  • cmd/pipeline-controller/helpers_test.go
  • pkg/retester/retester_test.go
  • cmd/ci-scheduling-webhook/prioritization.go
  • cmd/determinize-peribolos/main.go
  • images/publicize/Dockerfile
  • pkg/retester/testdata/testconfig/default.yaml
  • cmd/pr-reminder/README.md
  • cmd/pipeline-controller/main_test.go
  • cmd/ci-scheduling-webhook/mutation.go
  • cmd/pipeline-controller/pipeline_context_test.go
  • cmd/pipeline-controller/reconciler_test.go
  • cmd/pipeline-controller/config_data_provider.go
  • cmd/pr-reminder/main_test.go
  • cmd/backport-verifier/server_test.go

📝 Walkthrough

Walkthrough

This pull request removes multiple CLI tools, webhook services, and their associated components from the codebase, including backport verification, CI scheduling, GPU scheduling, helpdesk FAQ, pipeline automation, PR reminders, publicize, and retester functionality, along with corresponding container images and test coverage.

Changes

Cohort / File(s) Summary
backport-verifier
cmd/backport-verifier/main.go, cmd/backport-verifier/server.go, cmd/backport-verifier/server_test.go, images/backport-verifier/Dockerfile
Removes the complete backport verification webhook service, including CLI entrypoint, server handler logic for validating upstream PR merges, test suite, and container image build configuration.
ci-scheduling-webhook
cmd/ci-scheduling-webhook/main.go, cmd/ci-scheduling-webhook/mutation.go, cmd/ci-scheduling-webhook/prioritization.go, cmd/ci-scheduling-webhook/readme.md, cmd/ci-scheduling-webhook/monitoring/*, images/ci-scheduling-webhook/Dockerfile
Deletes the entire CI workload scheduling webhook, including admission mutation logic (pod/node patching), node scale-down orchestration, monitoring scripts, documentation, and container image configuration.
determinize-peribolos
cmd/determinize-peribolos/main.go, images/determinize-peribolos/Dockerfile
Removes the peribolos config formatting tool entrypoint and container image.
gpu-scheduling-webhook
cmd/gpu-scheduling-webhook/main.go, cmd/gpu-scheduling-webhook/main_test.go, cmd/gpu-scheduling-webhook/README.md, images/gpu-scheduling-webhook/Dockerfile
Eliminates the GPU node toleration webhook, its test coverage, documentation, and Dockerfile.
helpdesk-faq
cmd/helpdesk-faq/main.go, images/helpdesk-faq/Dockerfile
Removes the helpdesk FAQ HTTP service and container image.
pipeline-controller
cmd/pipeline-controller/main.go, cmd/pipeline-controller/config_data_provider.go, cmd/pipeline-controller/config_data_provider_test.go, cmd/pipeline-controller/config_watcher.go, cmd/pipeline-controller/config_watcher_test.go, cmd/pipeline-controller/helpers.go, cmd/pipeline-controller/helpers_test.go, cmd/pipeline-controller/main_test.go, cmd/pipeline-controller/pipeline_auto_cache.go, cmd/pipeline-controller/pipeline_context_test.go, cmd/pipeline-controller/reconciler.go, cmd/pipeline-controller/reconciler_test.go, images/pipeline-controller/Dockerfile
Removes the complete pipeline automation controller, including Kubernetes reconciliation logic, GitHub event handlers, config management, helper utilities, all test coverage, and container image.
pr-reminder
cmd/pr-reminder/main.go, cmd/pr-reminder/main_test.go, cmd/pr-reminder/README.md, images/pr-reminder/Dockerfile
Deletes the PR reminder service that sends Slack notifications, including CLI logic, test suite, documentation, and Dockerfile.
publicize
cmd/publicize/main.go, cmd/publicize/server.go, cmd/publicize/server_test.go, cmd/publicize/README.md, images/publicize/Dockerfile
Removes the publicize plugin for merging commit histories between repositories, including server logic, test coverage, documentation, and container image.
retester
cmd/retester/main.go, cmd/retester/main_test.go, pkg/retester/cache.go, pkg/retester/fileBackOffCache.go, pkg/retester/retester.go, pkg/retester/retester_test.go, pkg/retester/s3BackOffCache.go, pkg/retester/testdata/*, images/retester/Dockerfile
Eliminates the complete retester controller and supporting backoff cache implementations (file and S3-based), all unit/integration tests, test data fixtures, CLI entrypoint, and container image.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 14
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove tools extracted to ci-tools-standalone' clearly summarizes the main change: deletion of multiple tools that were moved to a separate repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR consists exclusively of file deletions with no new Go code additions, so no error handling patterns exist to evaluate.
Test Coverage For New Features ✅ Passed PR removes extracted tools without introducing new functionality, so custom check requiring test coverage for new features does not apply.
Stable And Deterministic Test Names ✅ Passed PR removes tools and associated code without introducing new test files or Ginkgo tests with dynamic information.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable; this PR only removes migrated code with no test changes.
Microshift Test Compatibility ✅ Passed This pull request removes previously existing tools and their associated code; it does not add any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only deletions of previously existing code and tests; no new Ginkgo e2e tests are being added.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes tools and code without adding scheduling constraints or topology assumptions, so the Topology-Aware Scheduling Compatibility check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR removes 9 tools that are Kubernetes webhooks, HTTP services, and Prow plugins—none are OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only deletions of existing code, tools, and tests—no new Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from droslean and pruan-rht April 30, 2026 09:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@jmguzik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes eadf7aa link false /test breaking-changes
ci/prow/images eadf7aa link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prucek
Copy link
Copy Markdown
Member

Prucek commented May 4, 2026

/lgtm
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants