Skip to content

Add go.work to gitignore#5137

Open
psalajova wants to merge 1 commit intoopenshift:mainfrom
psalajova:git-ignore-go-work
Open

Add go.work to gitignore#5137
psalajova wants to merge 1 commit intoopenshift:mainfrom
psalajova:git-ignore-go-work

Conversation

@psalajova
Copy link
Copy Markdown
Contributor

@psalajova psalajova commented Apr 27, 2026

After #5109 , creating a local go.work file with some dependency replacements was the only way I got imports in this repo working (this is a sad Goland IDE limitation in combination with broken v0.0.0 dependencies from kubernetes and assisted-service packages).

Summary by CodeRabbit

  • Chores
    • Updated repository configuration for Go workspace management.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1fb7599c-0e16-4c94-afc1-584739a1a98a

📥 Commits

Reviewing files that changed from the base of the PR and between 2a2401c and 091adf8.

📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

Updates .gitignore to exclude Go workspace files by adding go.work and go.work.sum entries, ensuring Go module workspace configurations are not tracked in version control.

Changes

Cohort / File(s) Summary
Go Workspace Configuration
.gitignore
Added entries to ignore Go workspace files (go.work, go.work.sum).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add go.work to gitignore' directly and accurately describes the main change in the pull request, which adds go.work and go.work.sum entries to .gitignore.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed The custom check for Go error handling patterns is not applicable to this pull request. The PR exclusively modifies the .gitignore configuration file by adding entries for Go workspace files (go.work and go.work.sum). Since no Go source code files (.go files) were changed, there is no Go code to assess against error handling patterns, panic usage, or pointer dereferencing guidelines.
Test Coverage For New Features ✅ Passed Pull request modifies only .gitignore file to add go.work and go.work.sum entries, which is a configuration-only change exempt from test coverage requirements.
Stable And Deterministic Test Names ✅ Passed PR only modifies .gitignore; contains no test files or Ginkgo test code, so check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies .gitignore file to add Go workspace entries. No Ginkgo test code or test-related changes present.
Microshift Test Compatibility ✅ Passed This pull request only modifies .gitignore to add Go workspace file entries and contains no new Ginkgo e2e tests, making the MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies .gitignore to add Go workspace file entries. No new Ginkgo e2e tests are added or modified, so SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only .gitignore by adding Go workspace entries. The topology-aware scheduling check is not applicable to Git configuration files.
Ote Binary Stdout Contract ✅ Passed Pull request modifies only .gitignore to add Go workspace files. No Go source code changes, so OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check for IPv6 and disconnected network test compatibility is not applicable. PR only modifies .gitignore with Go workspace file entries.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from hector-vido and smg247 April 27, 2026 13:04
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@psalajova: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 091adf8 link false /test breaking-changes
ci/prow/images 091adf8 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant