Skip to content

Clarify cluster operator Progressing condition #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongkailiu wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

Clarify cluster operator Progressing condition #2829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config/v1/types_cluster_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ const (
// is actively rolling out new code, propagating config changes (e.g, a version change), or otherwise
// moving from one steady state to another. Operators should not report
// Progressing when they are reconciling (without action) a previously known
// state. Operators should not report Progressing only because DaemonSets owned by them
// are adjusting to a new node from cluster scaleup or a node rebooting from cluster upgrade.
// state. Operators should not report Progressing only because resources owned by them,
// such as DaemonSets and Deployments, are adjusting to a new node from cluster scaleup
// or a node rebooting from cluster upgrade.
// If the observed cluster state has changed and the component is
// reacting to it (updated proxy configuration for instance), Progressing should become true
// since it is moving from one steady state to another.
Expand Down