Skip to content

convert MachineConfig features that can be done live to rebootless. - #503

Merged
openshift-merge-bot[bot] merged 9 commits into
openshift-virtualization:mainfrom
michalskrivanek:ndp_convert
Nov 6, 2026
Merged

openshift-merge-bot[bot] merged 9 commits into
openshift-virtualization:mainfrom
michalskrivanek:ndp_convert

Conversation

@michalskrivanek

Copy link
Copy Markdown
Contributor

Convert THP tuning, VM drain inhibitor, SCSI PR multipath policy, kubelet performance settings policy, and kubelet CPU manager policy to rebootless

Wire enable-thp-tuning MachineConfigs to a Node Disruption Policy so
THP tuning updates are done live; leave kernelcore as reboot only.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Extend the catalog NDP validity test so policy paths and units must
appear on a dependent MachineConfig, catching removals as well as gaps.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Wire the inhibitor MachineConfigs to a Node Disruption Policy so updates
restart logind and the inhibitor service without a node reboot.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Reload multipathd after writing reservation_key file so shared-LUN
PR key persistence does not require a node reboot.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Restart kubelet after applying the kubelet.conf.d drop-in so the
opt-in does not require a node reboot.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Restart kubelet after applying the cpu-manager drop-in so the opt-in
does not require a node reboot.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
multipath must already be configured

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
It conflicts with OpenShift's reserved-cgroup model and prevents kubelet from starting; keep kubeReserved for static + full-pcpus-only.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
Clearing cpu_manager_state via kubelet-cleanup.service is required for the
none↔static policy flip, otherwise kubelet complains about cpu checkpoint.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
Assisted-by: cursor-auto
@michalskrivanek

Copy link
Copy Markdown
Contributor Author

@fabiand FYI
@tiraboschi would you have time for deeper review? The kubelet MCs that had to be changed seem lightly tested(broken:) already so I'm not too worried about the change TBH

@tiraboschi

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Nov 6, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 4b83112 into openshift-virtualization:main Nov 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants