Repository navigation
convert MachineConfig features that can be done live to rebootless. - #503
Merged
openshift-merge-bot[bot] merged 9 commits intoNov 6, 2026
Merged
openshift-merge-bot[bot] merged 9 commits into
openshift-merge-bot[bot] merged 9 commits into
Conversation
Wire enable-thp-tuning MachineConfigs to a Node Disruption Policy so THP tuning updates are done live; leave kernelcore as reboot only. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Extend the catalog NDP validity test so policy paths and units must appear on a dependent MachineConfig, catching removals as well as gaps. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Wire the inhibitor MachineConfigs to a Node Disruption Policy so updates restart logind and the inhibitor service without a node reboot. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Reload multipathd after writing reservation_key file so shared-LUN PR key persistence does not require a node reboot. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Restart kubelet after applying the kubelet.conf.d drop-in so the opt-in does not require a node reboot. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Restart kubelet after applying the cpu-manager drop-in so the opt-in does not require a node reboot. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
multipath must already be configured Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
michalskrivanek
force-pushed
the
ndp_convert
branch
from
October 23, 2026 13:51
2e537a5 to
38cc4ba
Compare
It conflicts with OpenShift's reserved-cgroup model and prevents kubelet from starting; keep kubeReserved for static + full-pcpus-only. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
Clearing cpu_manager_state via kubelet-cleanup.service is required for the none↔static policy flip, otherwise kubelet complains about cpu checkpoint. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: cursor-auto
michalskrivanek
force-pushed
the
ndp_convert
branch
from
October 23, 2026 16:19
fe36f06 to
b711cc7
Compare
Contributor
Author
|
@fabiand FYI |
tiraboschi
approved these changes
Nov 6, 2026
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Nov 6, 2026
4b83112
into
openshift-virtualization:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert THP tuning, VM drain inhibitor, SCSI PR multipath policy, kubelet performance settings policy, and kubelet CPU manager policy to rebootless