SRVKP-12918: Fix responsive toolbar filter count to show active filter categories instead of total chips - #1217
Conversation
|
@ankrsinha: This pull request references SRVKP-12918 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR Reviewer Guide 🔍Warning
Here are some key observations to aid the review process:
|
…d of total chips Signed-off-by: Ankur Sinha <anksinha@redhat.com>
ea07e3b to
ca5cecc
Compare
adityavshinde
left a comment
There was a problem hiding this comment.
Can we change the description's screen recording, as it is showing "1 filters applied" but it is showing correct while I was reviewing ("1 filter applied") ?
The code changes are working fine.
Screencast.From.2026-07-28.16-56-44.mp4
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adityavshinde, ankrsinha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Okay, i will update the screen recording in the description. |
Type of Change
Summary
Fixes the responsive toolbar badge on PipelineRuns and TaskRuns list pages to display the number of active filter categories instead of the total number of selected filter values.
Problem:
When the toolbar collapses on smaller viewports, PatternFly counts every chip across all ToolbarFilter components.
Ex - Selecting both "Cluster" and "Archived" in the Data source filter plus a Time Range counted as 3, even though only 2 filter categories are active.
Fix:
Added
activeFilterCountthat counts filter categories with at least one selected value, and overrides PF's default count via thenumberOfFiltersTextprop on Toolbar.Screen Recordings / Screenshot
Screencast.From.2026-07-28.17-27-41.mp4