Skip to content

SRVKP-12864, SRVKP-12640, SRVKP-12806, SRVKP-12824: cve fix - adding resolution for js-yaml and lock file refresh for node tar, fast-uri - #1216

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:release-v1.22.xfrom
arvindk-softwaredev:fix/SRVKP-12864
Jul 28, 2026
Merged

SRVKP-12864, SRVKP-12640, SRVKP-12806, SRVKP-12824: cve fix - adding resolution for js-yaml and lock file refresh for node tar, fast-uri#1216
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:release-v1.22.xfrom
arvindk-softwaredev:fix/SRVKP-12864

Conversation

@arvindk-softwaredev

@arvindk-softwaredev arvindk-softwaredev commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

cve fix - adding resolution for js-yaml
lock file refresh for node tar, fast-uri is done as part of automated PR

Screen Recordings / Screenshot

yarn why
SRVKP-12864-yarn-why

yarn test
SRVKP-12864-yarn-test

yarn build
SRVKP-12864-yarn-build

UI sanity

SRVKP-12864-UI_Sanity.mov

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

@arvindk-softwaredev: This pull request references SRVKP-12864 which is a valid jira issue.

This pull request references SRVKP-12640 which is a valid jira issue.

This pull request references SRVKP-12806 which is a valid jira issue.

This pull request references SRVKP-12824 which is a valid jira issue.

Details

In response to this:

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

cve fix - adding resolution for js-yaml
lock file refresh for node tar, fast-uri is done in

Screen Recordings / Screenshot

yarn why

yarn test

yarn build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Jul 28, 2026
@arvindk-softwaredev
arvindk-softwaredev marked this pull request as ready for review July 28, 2026 07:21
@openshift-ci
openshift-ci Bot requested a review from vdemeester July 28, 2026 07:21
@arvindk-softwaredev
arvindk-softwaredev removed the request for review from vdemeester July 28, 2026 07:21
@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Potential incomplete CVE remediation:
the narrowly scoped js-yaml resolution selectors may leave vulnerable transitive dependency descriptors unaffected. Confirm the resulting lockfile contains no vulnerable js-yaml versions.

⚡ Recommended focus areas for review

Incomplete Resolution

The js-yaml resolutions target only dependencies whose requested descriptors exactly match 4.1.0 or 4.2.0. Validate that all vulnerable transitive descriptors, including ranges such as ^4.1.0, are overridden; otherwise vulnerable versions may remain installed.

"js-yaml@4.1.0": "4.3.0",
"js-yaml@4.2.0": "4.3.0"
Missing Lockfile

Dependency resolutions were changed without a corresponding lockfile update in this diff. Verify that immutable or frozen installs accept the manifest and that the committed dependency graph actually resolves all targeted packages to the patched versions.

"protobufjs": "^7.5.5",
"js-yaml@4.1.0": "4.3.0",
"js-yaml@4.2.0": "4.3.0"

@anwesha-palit-redhat anwesha-palit-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Looks Good to Me Label label Jul 28, 2026
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat,arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 082f4ac into openshift-pipelines:release-v1.22.x Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs Bug fix jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants