Fix IPv6 VIPs DNS lookup for baremetal deployments#1814
Fix IPv6 VIPs DNS lookup for baremetal deployments#1814mnietoji wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
Hi @mnietoji. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/test e2e-metal-ipi-bm Failed on an infra issue before it started testing the patch, seems like we should make sure it passes this job though. |
Issue when using Dual stack networking as EXTERNAL_SUBNET_V4 is defined. Instead, use IP_STACK for setting API_VIPS and INGRESS_VIPS for either IPV4, IPV6 or Dual stack
a88205d to
4d79122
Compare
|
/retest |
|
/lgtm Looks reasonable to me and passed the bm jobs. |
|
/retest-required |
|
hi, what else is needed to merge this PR? |
|
/assign @elfosardo |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mnietoji: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issue when using Dual stack networking as EXTERNAL_SUBNET_V4 is defined. Instead, use IP_STACK for setting API_VIPS and INGRESS_VIPS for either IPV4, IPV6 or Dual stack