fix(microshift-release): point GCS lookups at test-platform-results-public - #302
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhensel-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughProw result URLs and artifact downloads now use the ChangesProw results bucket
Plugin version
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to Prow status, scenario results, and artifact downloads now use the public results bucket with their existing paths. No concrete merge-blocking failure is evident. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ublic OpenShift CI retired anonymous access to the test-platform-results GCS bucket after a secret-leak incident (Sept 2026) and moved it behind Red Hat SSO as a read-only archive. New Prow job results are written only to test-platform-results-public now, so prow_testing.sh's status, scenarios, and download actions were silently finding nothing (GCS API returned 401/403, surfaced as "GCS API returned None" and every job showing as not-started regardless of actual state). Update GCS_API/GCS_BASE/PROW_VIEW in lib/prow.py, plus the gcsweb and gsutil download paths in prow_testing.py, to use the public bucket. Verified live against microshift/microshift#7487 — status now reports real job states instead of "-- (not started)" for everything. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
411bee1 to
189de8e
Compare
Patch bump for the test-platform-results-public GCS fix, required by the marketplace version-bump validation check. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
|
/lgtm |
Summary
test-platform-resultsGCS bucket after a secret-leak incident (Sept 2026) and moved it behind Red Hat SSO as a read-only archive. New Prow job results are now written only totest-platform-results-public.prow_testing.sh'sstatus/scenarios/downloadactions were pointed at the old bucket, so every job silently showed as not-started (GCS API returned None/401) regardless of actual CI state.GCS_API,GCS_BASE,PROW_VIEWinscripts/lib/prow.py, plus thegcswebandgsutildownload paths inscripts/prow_testing.py, to use the public bucket.Test plan
python3 -m pytest unit_tests/test_prow.py— 26/26 passopenshift/microshift#7487(4.21.36 release-testing PR) —prow_testing.sh status 4.21.36now correctly reports real job states (3 SUCCESS, 1 PENDING) instead of-- (not started)for all 4 jobs🤖 Generated with Claude Code
Summary by CodeRabbit