Skip to content

fix(microshift-release): point GCS lookups at test-platform-results-public - #302

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift-eng:mainfrom
dhensel-rh:gcs_bucket_public
Oct 5, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift-eng:mainfrom
dhensel-rh:gcs_bucket_public

Conversation

@dhensel-rh

@dhensel-rh dhensel-rh commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • OpenShift CI retired anonymous read access to the test-platform-results GCS bucket after a secret-leak incident (Sept 2026) and moved it behind Red Hat SSO as a read-only archive. New Prow job results are now written only to test-platform-results-public.
  • prow_testing.sh's status/scenarios/download actions were pointed at the old bucket, so every job silently showed as not-started (GCS API returned None/401) regardless of actual CI state.
  • Updates GCS_API, GCS_BASE, PROW_VIEW in scripts/lib/prow.py, plus the gcsweb and gsutil download paths in scripts/prow_testing.py, to use the public bucket.

Test plan

  • python3 -m pytest unit_tests/test_prow.py — 26/26 pass
  • Verified live against openshift/microshift#7487 (4.21.36 release-testing PR) — prow_testing.sh status 4.21.36 now correctly reports real job states (3 SUCCESS, 1 PENDING) instead of -- (not started) for all 4 jobs

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Scenario-result links, Prow views, and artifact downloads now use the public test-results bucket. Scenario results and how they are presented remain unchanged.
    • The MicroShift Release plugin version is now 1.8.1.

@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhensel-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f0ff9e24-f6fe-43e8-b1ab-04acc9c1c563

📥 Commits

Reviewing files that changed from the base of the PR and between 189de8e and b6a7968.

📒 Files selected for processing (2)
  • .claude-plugin/marketplace.json
  • plugins/microshift-release/.claude-plugin/plugin.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

Prow result URLs and artifact downloads now use the test-platform-results-public bucket. The PR prefix remains unchanged. Both microshift-release plugin manifests now specify version 1.8.1.

Changes

Prow results bucket

Layer / File(s) Summary
Update Prow bucket references
plugins/microshift-release/scripts/lib/prow.py, plugins/microshift-release/scripts/prow_testing.py
GCS API, artifact, viewer, and scenario-result URLs use the public bucket. Artifact downloads also use the public bucket. The PR prefix remains unchanged.

Plugin version

Layer / File(s) Summary
Update plugin version manifests
.claude-plugin/marketplace.json, plugins/microshift-release/.claude-plugin/plugin.json
Both manifests update the microshift-release plugin version from 1.8.0 to 1.8.1.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested labels: ready-for-human-review

Suggested reviewers: agullon

Merge Risk: ⚪ Minimal · up to b6a79

Prow status, scenario results, and artifact downloads now use the public results bucket with their existing paths. No concrete merge-blocking failure is evident.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating microshift-release GCS lookups to use the test-platform-results-public bucket.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed The pull request changes only GCS bucket URLs and plugin versions. The authoritative diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom cryptographic implementation, or non-constan…
Container-Privileges ✅ Passed PASS. The pull request changes only GCS URL strings and plugin version fields. The authoritative diff adds no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivilegeEs…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only GCS bucket and URL path constants, plus plugin versions. The diff adds no logging statements or sensitive values. The affected output and debug logs contain public GCS/Pr…
No-Hardcoded-Secrets ✅ Passed The PR adds only version strings and public GCS bucket URLs. The added lines contain no API keys, tokens, passwords, private keys, embedded URL credentials, secret-named literal assignments, or base64…
No-Injection-Vectors ✅ Passed PASS. The pull request changes only fixed GCS bucket URL constants and plugin versions. The new download path is passed to subprocess.run as an argument list without shell=True. The only `shell=Tr…
Ai-Attribution ✅ Passed AI use is disclosed in the PR description and commit messages. Both reviewed commits include an Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> trailer, and no Co-Authored-By trailer for an A…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Oct 2, 2026
…ublic

OpenShift CI retired anonymous access to the test-platform-results GCS
bucket after a secret-leak incident (Sept 2026) and moved it behind
Red Hat SSO as a read-only archive. New Prow job results are written
only to test-platform-results-public now, so prow_testing.sh's status,
scenarios, and download actions were silently finding nothing (GCS API
returned 401/403, surfaced as "GCS API returned None" and every job
showing as not-started regardless of actual state).

Update GCS_API/GCS_BASE/PROW_VIEW in lib/prow.py, plus the gcsweb and
gsutil download paths in prow_testing.py, to use the public bucket.
Verified live against microshift/microshift#7487 — status now reports
real job states instead of "-- (not started)" for everything.

Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
Patch bump for the test-platform-results-public GCS fix, required by
the marketplace version-bump validation check.

Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
@agullon

agullon commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 03e9d09 into openshift-eng:main Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants