Register missing TAN function for analytics engine - #5717
Merged
dai-chen merged 1 commit intoAug 25, 2026
Conversation
TAN was already declared in BuiltinFunctionName and tokenized in the SQL and PPL grammars, but was never registered in PPLFuncImpTable. On the Calcite path resolving it threw "Cannot resolve function: TAN", which surfaced to SQL callers as "Failed to plan query: unexpected error". The other trigonometric functions were registered, so the gap affected TAN only. Also document TAN in the PPL math function reference, which listed the other trigonometric functions but omitted it. Signed-off-by: Chen Dai <daichen@amazon.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
dai-chen
changed the title
TAN function for analytics engine
dai-chen
marked this pull request as ready for review
August 24, 2026 21:58
dai-chen
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
ahkcs,
anirudha,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
August 24, 2026 21:58
RyanL1997
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TANwas already declared in both the SQL and PPL grammars, and it works on the V2 engine, butPPLFuncImpTableregistered every other trigonometric function and omitted this one. On the PPL V3 and analytics engine path, the resolution therefore failed withIllegalStateException: Cannot resolve function: TAN. This PR registers the operator againstSqlStdOperatorTable.TAN, fixing both SQL and PPL path.Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.