test(integ-test): exclude with gates for analytics-engine and Prometheus suites from integTestRemote - #5709
Open
mengweieric wants to merge 1 commit into
Conversation
mengweieric
force-pushed
the
fix/integtestremote-mirror-integtest-exclusions
branch
from
August 20, 2026 04:01
54f7af5 to
0210c53
Compare
mengweieric
force-pushed
the
fix/integtestremote-mirror-integtest-exclusions
branch
from
August 20, 2026 04:05
0210c53 to
6289059
Compare
mengweieric
force-pushed
the
fix/integtestremote-mirror-integtest-exclusions
branch
from
August 20, 2026 04:15
2ce0abe to
f8658e8
Compare
… integTestRemote integTestRemote runs against an externally provided cluster, so it can neither install plugins nor set node-level settings. Two groups of suites depend on one of those and are still selected by it, so they fail during setup instead of being skipped. Analytics-engine suites. AnalyticsEngineCompatIT, AnalyticsEngineSecurityIT and AnalyticsEngineProfileIT create composite (parquet-backed) indices and depend on opensearch.experimental.feature.pluggable.dataformat.enabled and opensearch.experimental.feature.transport.stream.enabled. Each has a dedicated task whose testClusters block provisions that stack. These are added as an else branch on the existing analyticsEnabled gate so that all analytics-engine filtering for this task stays in one place. AnalyticsEngineSecurityIT is also the slowest suite in the run: its setup polls the security configuration API 60 times at one second intervals and only marks itself initialised on success, so every test method repeats the full wait before failing. Prometheus suites. integTest already skips PrometheusDataSourceCommandsIT, ShowDataSourcesCommandIT and InformationSchemaCommandIT when the caller passes -DignorePrometheus, and on Windows where Prometheus is not started. integTestRemote now honours the same condition; the block and its comment are taken from integTest unchanged. Both groups stay gated, so default behaviour does not change: the else branch is only taken when analyticsEnabled is false, the Prometheus group is opt-in through the existing flag, and the dedicated analyticsEngine*IT tasks are untouched. The security package is deliberately not excluded. Whether those suites can run depends on the cluster integTestRemote is pointed at -- it forwards https, user and password precisely so it can target a secured cluster -- so a build-time exclusion would remove a supported configuration. That case needs a runtime capability check instead. Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
mengweieric
force-pushed
the
fix/integtestremote-mirror-integtest-exclusions
branch
from
August 20, 2026 04:16
f8658e8 to
b53453a
Compare
mengweieric
marked this pull request as ready for review
August 20, 2026 04:52
mengweieric
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
ahkcs,
anirudha,
dai-chen,
joshuali925,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
August 20, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
integTestRemoteruns against an externally provided cluster (-Dtests.rest.cluster), so it can neither install plugins nor set node-level settings. Two groups of suites depend on one of those and are still selected by the task, so they fail during setup rather than being skipped.elsebranch on the existinganalyticsEnabledgateAnalyticsEngineCompatIT,AnalyticsEngineSecurityIT,AnalyticsEngineProfileITopensearch.experimental.feature.pluggable.dataformat.enabledand...transport.stream.enabled; each has a dedicated task whosetestClustersblock provisions that stackif (windows || ignorePrometheus), copied fromintegTestPrometheusDataSourceCommandsIT,ShowDataSourcesCommandIT,InformationSchemaCommandITObserved when running
integTestRemoteagainst a cluster without the analytics-engine stack:AnalyticsEngineSecurityIT— all 21 tests fail in setup, and the suite is by a wide margin the slowest in the run. Its setup polls the security configuration API 60 times at one-second intervals and only sets itsinitializedflag once the poll succeeds, so every test method repeats the full wait before failing.AnalyticsEngineProfileIT— itsindex.pluggable.dataformatindex creation returns 400, which the test treats as "index already exists", so later tests report a misleadingno such index404.AnalyticsEngineCompatIT— skips cleanly; it already self-guards with a@Beforeprobe of_cat/plugins([Backport 3.7] Skip AnalyticsEngineCompatIT when analytics-engine plugin is absent #5511). It is listed so the analytics-engine group stays complete if that guard is ever removed.@Aftercleanup.Change
Both groups stay gated, so default behaviour does not change. The
elsebranch is only taken whenanalyticsEnabledis false, the Prometheus group is opt-in through the existingignorePrometheusflag, and the dedicated:analyticsEngineCompatIT,:analyticsEngineSecurityITand:analyticsEngineProfileITtasks are untouched and continue to run all three suites against clusters that provision what they need.The analytics-engine exclusions are gated rather than added to the class-file exclusion list below, so that all analytics-engine filtering for this task stays together with the existing route-divergence exclusions.
Not included: the security package
integTestalso excludesorg/opensearch/sql/security/**, on the grounds that those suites run in:integTestWithSecurity. That reasoning does not carry over here, and this PR deliberately leaves them in place.integTestWithSecurityruns against its ownconfigureSecurityPlugin()test cluster, so it does not cover the remote case.integTestRemoteforwardshttps,userandpasswordspecifically so that it can be pointed at a secured cluster, and against an FGAC-enabled cluster the security suites are meaningful and should run. A build-time exclusion would remove that supported configuration.Whether those suites can run is a property of the cluster the task is pointed at — on a cluster without the security configuration API every
PUT /_plugins/_security/api/roles/*returns400 {"error":"no handler found for uri ..."}— which Gradle cannot determine at configuration time. That case needs a runtime capability check in the tests, not a static exclusion, and is left for separate work.Related Issues
No separate tracking issue.
Check List
--signoffor-s.The unchecked items are not applicable: this changes a test task's exclusion list and adds no functionality, API surface or user-facing behaviour.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.