Repository navigation
Truncate the extra inline copies of each document #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chishui
wants to merge
3
commits into
opensearch-project:main
Choose a base branch
from
chishui:truncate-extra-inline-copies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
(comps+vals) / (n_docs / num_vectors)is exact only if copy count doesn't correlate with doc length, but long docs sit in more posting lists: at T=0 base_full stores 15.85e9 nnz in 12.97 × 8.84M copies, 138 nnz/copy vs 126.8/doc. One copy is the corpus, 1,121,199,371 nnz × 3 B = 3.13 GiB, not the 3.42 at DISK_SEISMIC_BENCH.md:115 (by bytes the inline index holds ~14.1 copies; 12.97 is the count). TheT = …rows (L432) have a similar gap: they cut every copy to ≥T and keep no whole copy, so on the seed=42 T=0 file the T=48 row prints ~21.22 GiB where the T=48 build is 22.971 GiB (6.197e9 stored nnz, 39.1%). Tracking first sight with astd::vector<bool>(num_vectors)in the existing (pl, block) loop — full nnz the first time,min(T, nnz)after — reproduces the written nnz exactly (6,197,434,818 / 7,877,959,871 at T=48/64), and the same sum gives the true one-copy size. Could it also printfwd.max_doc_nnz()(nothing in the output says a file is truncated, and on a truncated file the lossy section runs over copies already cut) and skip the T rows ≥ it?