Skip to content

Clear copied GOPACS announcement inputs when the source GOPACS asset is gone #141

Open

Description

@Miggets7

EmsOptimisationService copies the announcement inputs from the GOPACS asset to its Distro siblings. Nothing clears them when the GOPACS asset is deleted, when the Distro asset moves to a parent without a GOPACS asset, or when the GOPACS asset moves away. The Distro asset keeps the old announcement and EAN, and a confirmation can still place an order until the bid validity end passes.

To decide:

  • Clear the inputs when the Distro asset has no lone GOPACS sibling. A cleared announcement ID makes DistroGopacsHandler cancel every open order. Is that wanted, or should open orders stay?
  • A GOPACS asset moving away needs its old parent from the persistence event.

Raised in review of #135 (#135 (comment)).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions