docs(workflows): clarify evidence-free acceptance criteria - #229
Conversation
6f3ad53 to
bfb4668
Compare
|
Updated this branch onto the latest upstream main. The PR remains a two-file documentation change; |
tt-a1i
left a comment
There was a problem hiding this comment.
Reviewed exact head 41a0ee6 against main a15a0d8. The documented attestation/evidence-backed distinction matches evaluateAcceptance: only declared requiredEvidence labels are enforced, and the existing scope criterion test confirms an accepted criterion may return an empty evidence array. Merge conflicts with #223 were resolved by preserving both the new limits/exact-match contract and this clarification. Local bun run check and bun run test passed (967 passed, 1 skipped); diff check passed.
tt-a1i
left a comment
There was a problem hiding this comment.
Reviewed exact head 25383d4 after updating onto main 2894084. The PR remains a two-file, three-line documentation clarification: criteria without requiredEvidence are attestations, while evidence-backed gates must declare labels. This matches the runtime contract and does not change behavior. Fresh required CI passed on Node 22.19.0, Node 24, and Windows; the branch is current with main. Approved for squash merge.
Problem
Acceptance criteria without
requiredEvidencecan pass from the child agent's status assertion alone, while the documentation presents acceptance as an evidence ledger without explaining this distinction. This can make callers assume a description-only criterion is independently evidence-backed.Value
Clarifies the current contract so contributors can choose between an attestation and an evidence-backed acceptance gate intentionally, without changing runtime semantics.
Approach
Document in the README and Workflow reference that a criterion without
requiredEvidenceis an attestation of its description, and that criteria requiring evidence-backed acceptance must declare the required evidence labels.Validation
node --test --experimental-strip-types tests/extensions/workflows/acceptance.test.ts— 5 passed.git diff --check— passed.Impact
Fixes #119