feat(setup): force explicit folder selection and warn about storage risk#33
Merged
mikebarkmin merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
…droid - Remove pre-populated default folder from setup wizard; user must explicitly pick a folder before they can proceed to the next step - Add _folderError state and folder-required validation in _onNext - Show italic "No folder chosen" placeholder when no folder selected - Clear _folderError when a folder is picked - Show error text (library_folder_required) under folder row on failed advance - Add _AndroidStorageNote widget shown only on Android, advising to pick shared storage (e.g. Documents) so data survives app reinstall - Return empty string from _databasePath when folder is null; only render the path preview when a folder has been chosen - Add translation keys: library_folder_required, library_storage_warning_android, no_folder_selected (en + de) - Update README with Data storage section explaining per-platform safe locations Agent-Logs-Url: https://github.com/openpatch/classi/sessions/cca00b9d-d7c1-4e10-83aa-1bf9d510408d Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/openpatch/classi/sessions/cca00b9d-d7c1-4e10-83aa-1bf9d510408d Co-authored-by: mikebarkmin <2592379+mikebarkmin@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mikebarkmin
April 28, 2026 07:24
View session
Member
|
/build android |
📦 Android build ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default library path silently used
getApplicationDocumentsDirectory(), which on Android and sandboxed macOS resolves to an app-private directory deleted on uninstall.Changes
Setup wizard — forced folder selection
_selectedFolderstarts asnull; the wizard no longer pre-populates a default pathlibrary_folder_requirederror inline under the folder row_databasePathreturns''while no folder is chosen; the path preview is hidden until a folder is selectedAndroid storage warning
_AndroidStorageNotewidget rendered only onPlatform.isAndroidadvises users to pick a folder in shared storage (e.g. Documents) so data survives reinstallTranslations (
en+de)no_folder_selectedlibrary_folder_requiredlibrary_storage_warning_androidREADME
Added Data storage section with a per-platform table of safe library locations and a note recommending auto-export backups.