Skip to content

Fix connection pagination with sorting#2239

Merged
alexandrudanpop merged 3 commits intomainfrom
fix/connection-pagination-with-sort
Apr 17, 2026
Merged

Fix connection pagination with sorting#2239
alexandrudanpop merged 3 commits intomainfrom
fix/connection-pagination-with-sort

Conversation

@alexandrudanpop
Copy link
Copy Markdown
Contributor

Fixes OPS-4153

@linear
Copy link
Copy Markdown

linear bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses OPS-4153 by fixing seek-pagination cursor encoding/decoding when listing App Connections with non-timestamp sorting (e.g., sorting by name), ensuring pagination works correctly with sorting applied.

Changes:

  • Pass a columnType through app-connection sorting config into the paginator’s custom pagination column.
  • Extend pagination cursor encode/decode helpers to treat Postgres character varying as a string type.
  • Update unit tests to assert the columnType value used for pagination.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/server/api/src/app/app-connection/app-connection-service/app-connection-service.ts Adds columnType to sorting resolution and forwards it into buildPaginator for connection listing pagination.
packages/server/api/src/app/helper/pagination/pagination-utils.ts Adds encode/decode support for the character varying type used in cursors.
packages/server/api/test/unit/app-connection/app-connection-service.test.ts Updates list tests to include assertions for columnType passed to buildPaginator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/server/api/src/app/helper/pagination/pagination-utils.ts
Comment thread packages/server/api/test/unit/app-connection/app-connection-service.test.ts Outdated
@alexandrudanpop alexandrudanpop enabled auto-merge (squash) April 17, 2026 13:38
@sonarqubecloud
Copy link
Copy Markdown

@alexandrudanpop alexandrudanpop merged commit bed797c into main Apr 17, 2026
21 checks passed
@alexandrudanpop alexandrudanpop deleted the fix/connection-pagination-with-sort branch April 17, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants