Remove self loops from spontaneous fission decay mode

[eepeterson]

Description

This PR just prevents spontaneous fission decay modes from erroneously adding source terms along the diagonal of the burnup matrix. Since the official depletion chains have this behavior, this seems like the easiest immediate fix, but it does warrant a discussion on whether the semantics should be changed in the chain file themselves.

Fixes #3906

Checklist

• I have performed a self-review of my own code
• I have run clang-format (version 18) on any C++ source files (if applicable)
• I have followed the style guidelines for Python source files (if applicable)
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works (if applicable)

[shimwell]

Skipping the gain term for sf in form_matrix() is a nice fix, and the path_rate != 0.0 guard to avoid explicit zeros in the sparse matrix is a nice cleanup too. It might be a while till the corrected chain files are used everywhere.

As a possible follow-up (separate PR), it might be worth also fixing this upstream in from_endf() so that sf decay modes get target=None instead of the self-referential target when generating chain files. That way the existing if target is not None guard in form_matrix() would handle it naturally without needing the sf-specific check. But that's a bigger change since it means regenerating the official chain files too, so totally fine as a future thing.

[eepeterson]

I agree, but if you wanted to add spontaneous fission yields to actually populate the correct gain terms you'd still need a specific check for 'sf' somewhere probably after the alpha and proton gain terms. I do tend to agree that None should be the correct target in the chain files.

[paulromano]

Thanks @eepeterson for the PR and @shimwell for the further suggestion. I've fixed the underlying issue here, which is that DecayMode.daughter was returning the parent nuclide for the 'sf' decay mode; now it returns None.