Editorial fixes to the Risk Level Change use case - #353
Open
mike-kiser-sp wants to merge 1 commit into
Open
mike-kiser-sp wants to merge 1 commit into
mike-kiser-sp wants to merge 1 commit into
Conversation
Follow-ups to openid#349, all confined to the section it added. - Defer the allowable values of current_level to CAEP rather than enumerating them inline. openid#330 proposes adding UNKNOWN to that enum, which would leave the profile carrying a stale list. The other fields in the section, and Sections 3.1-3.3, already defer to CAEP. - Use "Section 3.8.1" rather than the section sign. The document sets coding: us-ascii, so the section sign is transliterated and the published text currently renders as "1.0 S.3.8.1". - Strip trailing whitespace from three definition list terms, which kramdown would otherwise treat as line breaks. - Restore the trailing newline at end of file. No normative change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
The change looks good to me. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #349, all confined to the section it added. No normative change.
1. Defer
current_levelvalues to CAEP instead of enumerating themThe merged text hardcodes
(LOW, MEDIUM, HIGH). #330 proposes addingUNKNOWNto that enum in CAEP, which would leave the profile carrying a stale list.This is also inconsistent within the section as merged:
principalandprevious_levelboth say "all allowable values" and defer to CAEP, as do Sections 3.1-3.3. Onlycurrent_levelenumerates.2.
Section 3.8.1rather than the section signThe document sets
coding: us-ascii, so§is transliterated by kramdown. The published page currently reads "1.0 S.3.8.1" — see Section 3.4. The{{XXX}} Section Nform is used 18 times elsewhere in the document.Both occurrences are in the newly added section.
3. Trailing whitespace on three definition-list terms
current_level,previous_level,reason_admin— kramdown treats trailing whitespace as a line break.4. Trailing newline at end of file
The file ended mid-line, so any future edit to the document history would carry a spurious extra line in its diff.
Verified with
kramdown-rfc2629: builds clean, and the{{CAEP}}xref resolves to<xref target="CAEP"/> 1.0 Section 3.8.1in both places.Replaces #352, which could not be reopened after a force-push.