ARAP: make example binding artifacts conform to the profile - #690
Open
vatsalgupta wants to merge 1 commit into
Open
vatsalgupta wants to merge 1 commit into
vatsalgupta wants to merge 1 commit into
Conversation
Every example binding_token decoded to correlation data only, with no aud (which a conforming Access Request Service must reject), no iss or exp, and no binding material, so none illustrated the self-contained token the independent-service requirement calls for. The example approval.state values lacked the aud and iss the Approval State section requires. Replace all 13 example artifacts across the base profile and the four companions with ES256 JWS values that: * carry iss, aud, iat, exp, jti, evaluation_id, denial_expires_at, binding_context_members, and binding_hash for denial binding; * use the hashed form, since the inline claim names are not yet defined (openid#660); * compute binding_hash with the exact construction in Hash Construction (and the bulk construction in the Bulk profile) over each example's submitted tuple; * carry iss, aud, exp, approval_id, and binding_context_members for approval.state, with exp no later than approved_until. The Callback profile's approval.state previously expired at 17:00 while approved_until was 17:30; the new value expires with the approval. Deployment-specific claims already present (class, scope, bundle_id) are kept. Issuer and audience values use the policy_decision_point and access_request_endpoint URLs from the PDP metadata example, pending openid#661. No normative text changes. Refs openid#660
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the editor task from #660. The example tokens were not valid under the profile.
Problem
binding_tokenheld only anevaluation_id. It had noaud, so a conforming Access Request Service would have to reject it.approval.statevalues had noissoraud.approval.stateexpired at 17:00 butapproved_untilwas 17:30.Change
binding_hashis computed with the Hash Construction section over that example's submission.Notes
issandauduse the URLs from the PDP metadata example, pending ARAP: issuer and audience identifiers and key discovery #661.I checked all 13 against the verification steps in the text. The keys are throwaway. The public keys are below if anyone wants to check.
Example JWK Set
{ "keys": [ { "kty": "EC", "crv": "P-256", "kid": "pdp-1", "use": "sig", "alg": "ES256", "x": "qKRYVWkmMg8XhEVJwcgkdLsDuM4MgzDtM4H0eTkpOOo", "y": "ZVqOEQYtNr0Ip6wJV4Gj-gP2G-DHRxONoWhFzLIj6Jk" }, { "kty": "EC", "crv": "P-256", "kid": "ars-1", "use": "sig", "alg": "ES256", "x": "qEkmS8NSDNjRoS6KONu-jweL79joBNZGX0XAYf5Ahb4", "y": "jHOLMTAMS8qTjoSAIS6l-vlTcOxD34G1CsVyoRtLyX8" } ] }Refs #660