Skip to content

Improve private notes voice flows#256

Open
Ju-usc wants to merge 3 commits intoopenhome-dev:devfrom
Ju-usc:feat/private-notes-clean
Open

Improve private notes voice flows#256
Ju-usc wants to merge 3 commits intoopenhome-dev:devfrom
Ju-usc:feat/private-notes-clean

Conversation

@Ju-usc
Copy link
Copy Markdown
Contributor

@Ju-usc Ju-usc commented Apr 24, 2026

Summary

  • improve the Private Notes voice flow for create, read, search, overwrite, and delete requests
  • keep note contents out of the prompt by passing only a note index unless search/read is needed
  • add safer persistence behavior, confirmation handling, and more voice-friendly responses

Validation

  • python3 validate_ability.py community/private-notes
  • python3 -m py_compile community/private-notes/main.py

Copilot AI review requested due to automatic review settings April 24, 2026 02:57
@Ju-usc Ju-usc requested a review from a team as a code owner April 24, 2026 02:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🔀 Branch Merge Check

PR direction: feat/private-notes-cleandev

Passedfeat/private-notes-cleandev is a valid merge direction

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

✅ Community PR Path Check — Passed

All changed files are inside the community/ folder. Looks good!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

✅ Ability Validation Passed

📋 Validating: community/private-notes
  ✅ All checks passed!

@github-actions github-actions Bot added the community-ability Community-contributed ability label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🔍 Lint Results

Files linted: community/private-notes/main.py

✅ Flake8 — Passed

✅ All checks passed!

@Ju-usc Ju-usc mentioned this pull request Apr 24, 2026
19 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the Private Notes voice flow by adding topic search, reducing prompt exposure of note bodies by default, and centralizing destructive-action confirmations in Python for consistent safety behavior.

Changes:

  • Added search_notes tool and updated the voice loop contract to support topic/keyword queries.
  • Adjusted tool loop parsing/handling to be more resilient and to prevent confirmations via ask_followup.
  • Hardened persistence behavior by validating stored notebook shape and refusing to operate on malformed storage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
community/private-notes/SPEC.md Updates spec to add search, Python-owned confirmations, and malformed-storage safety rules.
community/private-notes/README.md Documents new search behavior and voice UX expectations around confirmations/titles.
community/private-notes/main.py Implements search_notes, confirmation-question generation, stricter notebook validation, and improved tool-call parsing/loop behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread community/private-notes/main.py
Comment thread community/private-notes/main.py Outdated
Comment thread community/private-notes/main.py Outdated
@Ju-usc Ju-usc force-pushed the feat/private-notes-clean branch 2 times, most recently from ba91772 to 2ad9392 Compare April 24, 2026 06:49
@Ju-usc Ju-usc force-pushed the feat/private-notes-clean branch from 2ad9392 to 6f14726 Compare April 24, 2026 07:24
@zainirfan13 zainirfan13 requested a review from a team as a code owner April 26, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-ability Community-contributed ability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants