Skip to content

More issues with pressure #213

Closed

Description

@lilyminium

I found a couple more pressure issues --

  1. Pressure not properly passed to msgpack:

    pressure=pressure if pressure is None else openmm.unit.kilopascal,
    This doesn't actually pass the pressure, just the unit itself. Same error in _equilibrate.py .

  2. Jacobian computation still assumes atmosphere:

    None if pressure is None else pressure * openmm.unit.atmosphere,

    (and there's a comment earlier that also assumes it's in atmosphere:
    pressure = compute_config.get("pressure") # atmosphere, float | None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions