Skip to content

Remove prop-types from all TypeScript components#4221

Open
bradenmacdonald wants to merge 2 commits into
release-23.xfrom
braden/remove-prop-types
Open

Remove prop-types from all TypeScript components#4221
bradenmacdonald wants to merge 2 commits into
release-23.xfrom
braden/remove-prop-types

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Description

Finishes up #3744 by removing propTypes from all remaining TypeScript components that didn't already have a PR open.

Deploy Preview

Compare the documentation pages for the affected components:

Component This PR Version 23
Card / BaseCard Props API Props API
ChipIcon no docs page? no docs page?
ModalDialogHeader Props API Props API
Overlay Props API Props API
Tooltip Props API Props API
Other changes CSS Utilities CSS Utilities

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 14, 2026
@netlify

netlify Bot commented Apr 14, 2026

Copy link
Copy Markdown

Deploy Preview for paragon-openedx-v23 ready!

Name Link
🔨 Latest commit 7eeeda7
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/6a3dc1b3ddfb6900082351ae
😎 Deploy Preview https://deploy-preview-4221--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openedx-webhooks

openedx-webhooks commented Apr 14, 2026

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 14, 2026
@bradenmacdonald bradenmacdonald marked this pull request as draft April 14, 2026 01:32
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 16, 2026
@bradenmacdonald bradenmacdonald force-pushed the braden/remove-prop-types branch 3 times, most recently from 5d4b269 to 5a26838 Compare June 25, 2026 23:26
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.25%. Comparing base (9340b9c) to head (7eeeda7).
⚠️ Report is 5 commits behind head on release-23.x.

Files with missing lines Patch % Lines
src/Overlay/index.tsx 46.66% 7 Missing and 1 partial ⚠️
src/Chip/ChipIcon.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #4221      +/-   ##
================================================
- Coverage         94.40%   94.25%   -0.15%     
================================================
  Files               242      242              
  Lines              4309     4301       -8     
  Branches            981     1024      +43     
================================================
- Hits               4068     4054      -14     
- Misses              237      238       +1     
- Partials              4        9       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald bradenmacdonald force-pushed the braden/remove-prop-types branch 2 times, most recently from 0c49e6a to 2c55c9f Compare June 25, 2026 23:45
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bradenmacdonald bradenmacdonald force-pushed the braden/remove-prop-types branch from 2c55c9f to 4505310 Compare June 25, 2026 23:49
@bradenmacdonald bradenmacdonald force-pushed the braden/remove-prop-types branch from 8a74dd5 to 7eeeda7 Compare June 26, 2026 00:02
@bradenmacdonald bradenmacdonald marked this pull request as ready for review June 26, 2026 00:03
@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

@brian-smith-tcril or @peterkulko would one of you be able to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants