Skip to content

test: move some library event tests from test_api to test_events [FC-0117]#38407

Open
bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
open-craft:braden/events-test-improvements
Open

test: move some library event tests from test_api to test_events [FC-0117]#38407
bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
open-craft:braden/events-test-improvements

Conversation

@bradenmacdonald
Copy link
Copy Markdown
Contributor

@bradenmacdonald bradenmacdonald commented Apr 22, 2026

Description

To make my other PR openedx/openedx-core#543 easier to review, and easier to compare its before-and-after effects, this PR moves some content libraries tests from test_api.py to test_events.py, updates them to match the style and detail of the other events tests, and makes them more comprehensive by adding the CONTENT_OBJECT_ASSOCIATIONS_CHANGED event to the event tests, which were previously ignoring it.

This addresses the longstanding TODO in the code:

# TODO: move more of the event-related collection tests from test_api.py to here, and convert them to use REST APIs

Testing instructions

Just make sure the tests are passing and the new tests are similar in coverage and effect to the deleted tests. This PR only changes test code and has no effects on the application code itself.

Deadline

ASAP

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 22, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bradenmacdonald bradenmacdonald force-pushed the braden/events-test-improvements branch from 92695ae to 036c415 Compare April 22, 2026 03:18
@bradenmacdonald
Copy link
Copy Markdown
Contributor Author

@ormsbee @kdmccormick Could I please get a review from one of you on this PR? It is just refactoring the content libraries event tests, without any changes to how the events work.

This change will make it much easier to validate my other PRs that majorly refactor how the library events get emitted.

@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Apr 22, 2026
@bradenmacdonald bradenmacdonald changed the title test: move some library event tests from test_api to test_events test: move some library event tests from test_api to test_events [FC-0117] Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants