feat: added redirect to new instructor dash#38396
feat: added redirect to new instructor dash#38396holaontiveros wants to merge 10 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Here are some suggestions and things to think through.
114b019 to
97989a6
Compare
|
Looks like enabling this flag is going to cause many instructor unit tests to fail because of 302 response instead of 200 |
This is enabled by default, the flag disables it, but yes a couple of tests break, the tests are related with some email related tests that expected the old section of instructor to exists and even have the a link for email section even if the email section only had a link to the communications MFE I'm fixing those by getting the flag enabled and letting the tests do their previous functionality |
Description
This PR enables by default a redirection from the old instructor dashboard views to the new instructor dashboard front end app
instructor.legacy_instructor_dashboard_mfeSupporting information
relates to openedx/frontend-base#229
Testing instructions
While having the latest from tutor-mfe at the frontend-base branch:
Deadline
None
Other information
No database migrations, no runtime changes, no deprecations.