Skip to content

feat: added redirect to new instructor dash#38396

Open
holaontiveros wants to merge 10 commits intoopenedx:masterfrom
WGU-Open-edX:feat/instructor-dash-redirect
Open

feat: added redirect to new instructor dash#38396
holaontiveros wants to merge 10 commits intoopenedx:masterfrom
WGU-Open-edX:feat/instructor-dash-redirect

Conversation

@holaontiveros
Copy link
Copy Markdown
Contributor

@holaontiveros holaontiveros commented Apr 20, 2026

Description

This PR enables by default a redirection from the old instructor dashboard views to the new instructor dashboard front end app

  • Course author, staff or anyone with the instructor dashboard access will now see by default the new frontendapp
  • A waffle flag is introduced that will enable the legacy dashboard instructor.legacy_instructor_dashboard_mfe

Supporting information

relates to openedx/frontend-base#229

Testing instructions

While having the latest from tutor-mfe at the frontend-base branch:

  • Try to access the instructor dashboard
  • You should be redirected to the new instructor dash

Deadline

None

Other information

No database migrations, no runtime changes, no deprecations.


@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 20, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Copy Markdown
Contributor

@wgu-taylor-payne wgu-taylor-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Here are some suggestions and things to think through.

Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/utils.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py
Comment thread lms/djangoapps/instructor/toggles.py
Comment thread lms/djangoapps/utils.py Outdated
Copy link
Copy Markdown
Contributor

@wgu-taylor-payne wgu-taylor-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Here are some further suggestions. Also, I want to make sure the implementation for the flag has more eyes on it than mine. @feanil @sarina.

Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/instructor/views/instructor_dashboard.py Outdated
Comment thread lms/djangoapps/courseware/tests/test_view_authentication.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py Outdated
Comment thread lms/djangoapps/instructor/toggles.py
Comment thread lms/djangoapps/instructor/toggles.py Outdated
@holaontiveros holaontiveros force-pushed the feat/instructor-dash-redirect branch from 114b019 to 97989a6 Compare April 21, 2026 19:34
@sarina
Copy link
Copy Markdown
Contributor

sarina commented Apr 21, 2026

Looks like enabling this flag is going to cause many instructor unit tests to fail because of 302 response instead of 200

@holaontiveros
Copy link
Copy Markdown
Contributor Author

Looks like enabling this flag is going to cause many instructor unit tests to fail because of 302 response instead of 200

This is enabled by default, the flag disables it, but yes a couple of tests break, the tests are related with some email related tests that expected the old section of instructor to exists and even have the a link for email section even if the email section only had a link to the communications MFE

I'm fixing those by getting the flag enabled and letting the tests do their previous functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

5 participants