Skip to content

Pair tarfile hard-link / symlink checks with the correct predicate #38390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pair tarfile hard-link / symlink checks with the correct predicate #38390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c424822
Pair tar hard-link / symlink checks with the correct tarfile predicate
Chessing234 Apr 20, 2026
6e04819
Merge branch 'master' into fix/extract-archive-symlink-hardlink-swap
e0d Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openedx/core/lib/extract_archive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ def _check_tarinfo(finfo: TarInfo, base: str):
SuspiciousOperation: If the TarInfo object is found to be a
hard link, symlink, or a special device file.
"""
if finfo.issym() and _is_bad_link(finfo, base):
if finfo.islnk() and _is_bad_link(finfo, base):
log.debug("File %r is blocked: Hard link to %r", finfo.name, finfo.linkname)
raise SuspiciousOperation("Hard link")
if finfo.islnk() and _is_bad_link(finfo, base):
if finfo.issym() and _is_bad_link(finfo, base):
log.debug("File %r is blocked: Symlink to %r", finfo.name, finfo.linkname)
raise SuspiciousOperation("Symlink")
if finfo.isdev():
Expand Down
Loading