Skip to content

Use try/hash() to detect uncacheable args in process_cached #38389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Use try/hash() to detect uncacheable args in process_cached #38389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e614a
Use try/hash to detect uncacheable args in process_cached
Chessing234 Apr 20, 2026
9c1cd87
Merge branch 'master' into fix/process-cached-uncacheable-args-hash-c…
e0d Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openedx/core/lib/cache_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"""


import collections
import functools
import itertools
import pickle
Expand Down Expand Up @@ -125,7 +124,9 @@ def __init__(self, func):
self.cache = {}

def __call__(self, *args):
if not isinstance(args, collections.abc.Hashable):
try:
hash(args)
except TypeError:
# uncacheable. a list, for instance.
# better to not cache than blow up.
return self.func(*args)
Expand Down
Loading