You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Merge LMS/CMS settings with partially overlapping values by using Derived values #37280
Find settings defined in lms/envs/common.py and cms/envs/common.py with overlapping, but not equal, values. Where possible, bring these settings up into openedx/envs/common.py where the value is defined with both the overlapping part, and then the non-overlapping part becomes based on values from settings in {lms/cms}/envs/common.py. This is accomplished by using a Derived value.
For example, we currently have HELP_TOKENS_INI_FILE defined like so in the common.py files:
If possible, we bring up HELP_TOKENS_INI_FILE into openedx/envs/common.py as a Derived setting that depends on the final value of REPO_ROOT and some other variable that holds the application name (i.e. "lms" or "cms"), such as SERVICE_VARIANT.
As part of this work, look to change MAKO_TEMPLATE_DIRS_BASE to a Derived setting if possible, making it possible to remove the lms.envs.commondependency from cms/envs/common.py. If we cannot accomplish this via a Derived setting, create a ticket to refactor this in some other way that allows us to remove the lms.envs.common dependency.
Activity
wgu-taylor-payne commentedon Sep 11, 2025
As part of this work, look to change
MAKO_TEMPLATE_DIRS_BASEto aDerivedsetting if possible, making it possible to remove thelms.envs.commondependency fromcms/envs/common.py. If we cannot accomplish this via aDerivedsetting, create a ticket to refactor this in some other way that allows us to remove thelms.envs.commondependency.Relevant discussion can be found here.