Skip to content

Course-to-Library Import: Drop old implementation #37242

Closed

Description

@kdmccormick

We had tried to implement the initial Import API for Teak, under the app name import_from_modulestore. We decided not to launch for Teak.

For Ulmo, we've taken the opportunity to start fresh, under the app name modulestore_migrator (#36873).

This means we need to drop the import_from_modulestore app. PRs:

  1. feat!: Drop import_from_modulestore app (1/3 -- code only) #37239
  2. feat!: Drop import_from_modulestore app (2/3 -- models) #37240
  3. feat!: Drop import_from_modulestore app (3/3 -- uninstall app) #37241

This 3-step process is based on https://openedx.atlassian.net/wiki/spaces/COMM/pages/1051361376/Removing+a+Djangoapp+from+an+existing+project

Activity

  1. self-assigned this
    on Aug 19, 2025
  2. kdmccormick commented on Aug 19, 2025

    @kdmccormick
    MemberAuthor

    FYI @cmltaWt0 , I'll be getting these merged soon so that you we can merge modulestore_migrator without worry about the old code.

  3. kdmccormick commented on Aug 19, 2025

    @kdmccormick
    MemberAuthor

    @cmltaWt0 Do you mind reviewing these 3 PRs?

  4. cmltaWt0 commented on Aug 20, 2025

    @cmltaWt0
    Contributor

    @cmltaWt0 Do you mind reviewing these 3 PRs?

    Sure, will do tomorrow.

  5. UsamaSadiq commented on Aug 25, 2025

    @UsamaSadiq
    Member

    Approved the first PR in the list. Assuming the failures in the 2nd and 3rd PR will be fixed when the 1st one is merged. I haven't looked deep into the 2nd and 3rd PR for now.

  6. kdmccormick commented on Aug 25, 2025

    @kdmccormick
    MemberAuthor

    Thanks!

  7. kdmccormick commented on Aug 25, 2025

    @kdmccormick
    MemberAuthor

    Approved the first PR in the list. Assuming the failures in the 2nd and 3rd PR will be fixed when the 1st one is merged.

    Yes, the first PR updates unit-test-shards.json to remove the app, which I expect will fix the next two PRs' tests.

  8. UsamaSadiq commented on Aug 25, 2025

    @UsamaSadiq
    Member

    Approved the first PR in the list. Assuming the failures in the 2nd and 3rd PR will be fixed when the 1st one is merged.

    Yes, the first PR updates unit-test-shards.json to remove the app, which I expect will fix the next two PRs' tests.

    Approved both of the follow up PRs too so you can go ahead and merge them as soon as CI is green after rebasing.

  9. kdmccormick commented on Sep 3, 2025

    @kdmccormick
    MemberAuthor

    Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions