You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Course-to-Library Import: Drop old implementation #37242
Approved the first PR in the list. Assuming the failures in the 2nd and 3rd PR will be fixed when the 1st one is merged. I haven't looked deep into the 2nd and 3rd PR for now.
Activity
kdmccormick commentedon Aug 19, 2025
FYI @cmltaWt0 , I'll be getting these merged soon so that you we can merge modulestore_migrator without worry about the old code.
kdmccormick commentedon Aug 19, 2025
@cmltaWt0 Do you mind reviewing these 3 PRs?
cmltaWt0 commentedon Aug 20, 2025
Sure, will do tomorrow.
UsamaSadiq commentedon Aug 25, 2025
Approved the first PR in the list. Assuming the failures in the 2nd and 3rd PR will be fixed when the 1st one is merged. I haven't looked deep into the 2nd and 3rd PR for now.
feat!: Drop import_from_modulestore app (1/3 -- code only) (#37239)
kdmccormick commentedon Aug 25, 2025
Thanks!
kdmccormick commentedon Aug 25, 2025
Yes, the first PR updates unit-test-shards.json to remove the app, which I expect will fix the next two PRs' tests.
UsamaSadiq commentedon Aug 25, 2025
Approved both of the follow up PRs too so you can go ahead and merge them as soon as CI is green after rebasing.
feat!: Drop import_from_modulestore app (2/3 -- models) (#37240)
feat!: Drop import_from_modulestore app (3/3 -- uninstall app) (#37241)
kdmccormick commentedon Sep 3, 2025
Done
feat!: Drop import_from_modulestore app (1/3 -- code only) (openedx#3…
feat!: Drop import_from_modulestore app (2/3 -- models) (openedx#37240)
feat!: Drop import_from_modulestore app (3/3 -- uninstall app) (opene…
chore: enrollment_date added to csv report and add custom fields method