Skip to content

feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path#547

Merged
kdmccormick merged 1 commit intomainfrom
kdmccormick/keys-media
Apr 21, 2026
Merged

feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path#547
kdmccormick merged 1 commit intomainfrom
kdmccormick/keys-media

Conversation

@kdmccormick
Copy link
Copy Markdown
Member

@kdmccormick kdmccormick commented Apr 15, 2026 •
edited
Loading

BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path

BREAKING CHANGE: In create_component_version_media(...), renamed param key -> path.
BREAKING CHANGE: In look_up_component_version_media(...), renamed param key -> path.

Part of: #322

Full series of PRs:

  1. feat!: Collection.key -> Collection.collection_code #542
  2. feat!: Component.local_key -> Component.component_code #544
  3. feat!: Add Container.container_code field #545
  4. feat!: Package and Entity keys are now opaque refs #546
  5. feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path #547

Testing, AI Usage, and Merge Considerations

See #322

This was referenced Apr 15, 2026
Merged
Merged
Merged
Merged
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch 3 times, most recently from 0b01361 to 52fe205 Compare April 15, 2026 10:26
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch from ca5d407 to bb6edbd Compare April 15, 2026 10:27
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch from 52fe205 to b9d11db Compare April 16, 2026 20:48
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch 2 times, most recently from 64d820e to 5c28c6f Compare April 16, 2026 23:00
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch from 09bbd04 to 3f23389 Compare April 17, 2026 16:43
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch from 5c28c6f to 9bc8916 Compare April 17, 2026 16:45
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch from 29580c7 to 3a446d5 Compare April 17, 2026 17:01
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch from 9bc8916 to 88a3564 Compare April 17, 2026 17:05
@kdmccormick kdmccormick mentioned this pull request Apr 17, 2026
Open
@kdmccormick kdmccormick marked this pull request as ready for review April 17, 2026 17:59
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch 2 times, most recently from 39d0c53 to 72a9868 Compare April 17, 2026 18:28
kdmccormick
kdmccormick commented Apr 17, 2026
View reviewed changes
Comment thread src/openedx_content/applets/components/admin.py
Comment on lines -53 to +55
class ContentInline(admin.TabularInline):
class MediaInline(admin.TabularInline):
"""
Django admin configuration for Content
Django admin configuration for Media
Copy link
Copy Markdown
Member Author

@kdmccormick kdmccormick Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, just something I noticed

@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch from 28197b9 to 9d0ed28 Compare April 17, 2026 18:48
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch from 72a9868 to f00160d Compare April 17, 2026 18:48
ormsbee
ormsbee approved these changes Apr 17, 2026
View reviewed changes
Comment thread src/openedx_content/applets/components/admin.py


class ContentInline(admin.TabularInline):
class MediaInline(admin.TabularInline):
Copy link
Copy Markdown
Contributor

@ormsbee ormsbee Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I feel silly for missing that one.

@bradenmacdonald
Copy link
Copy Markdown
Contributor

bradenmacdonald commented Apr 17, 2026

I won't review this PR; Dave's ✅ is good :)

@kdmccormick kdmccormick force-pushed the kdmccormick/keys-ref branch 2 times, most recently from 1a51119 to 02c300d Compare April 21, 2026 15:27
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch 2 times, most recently from 8d11d63 to f91dd6d Compare April 21, 2026 15:36
Base automatically changed from kdmccormick/keys-ref to main April 21, 2026 16:50
@kdmccormick @claude
feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path
63f6356 
BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path
BREAKING CHANGE: In create_component_version_media(...) and
                 look_up_component_version_media(...), renamed param key -> path.

Part of: #322

Bumps version to 0.43.0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@kdmccormick kdmccormick force-pushed the kdmccormick/keys-media branch from f91dd6d to 63f6356 Compare April 21, 2026 16:54
@kdmccormick kdmccormick enabled auto-merge (squash) April 21, 2026 16:55
@kdmccormick kdmccormick merged commit d0dc9cd into main Apr 21, 2026
6 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/keys-media branch April 21, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald left review comments

@ormsbee ormsbee ormsbee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kdmccormick @bradenmacdonald @ormsbee