Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3320 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 1446 1446
Lines 35384 35386 +2
Branches 8179 8476 +297
========================================
+ Hits 34041 34043 +2
+ Misses 1301 1285 -16
- Partials 42 58 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the pull request, @AShatsila! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Fixes openedx/openedx-core#873. On the Competency Management page, the competency tree (left column) and the course panel (right column) now have the same fixed height on desktop, at any screen size and zoom level. When the course list doesn't fit in that height, it scrolls inside the panel instead of making the panel taller.
The columns had different heights for two reasons:
.competency-treewascalc(100vh - 260px), so it was 820px tall at a 1920x1080 viewport and 508px at 1366x768.align-items: stretch, which makes both columns as tall as the taller one. With a full page of 10 courses, the course panel was always the taller one, so it set the height of the row. Itsoverflow-y: autonever took effect, and expanding a course made the panel taller still.Roles affected: Course Author (Competency Management page).
Screenshots: a 1920x1080 viewport with 10 courses on the first of 3 pages.
| Before
| After
Heights measured in the browser, tree column / course column, in px:
Supporting information
Testing instructions
You need a Competency taxonomy and a Studio instance with more than 10 courses, so that the course panel shows a full page and the pagination.
/authoring/taxonomy/<id>/competencies) on a desktop-width window and select any competency.Other information
competency-managementtests pass. The heights above were measured in a headless Chromium against a local Tutor devstack./api/contentstore/v2/home/coursesresponse with 10 courses. The first one, "Demonstration Course", is the real demo course, so its outline loads when it is expanded.Best Practices Checklist
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'🤖 Generated with Claude Code