refactor: remove unused team-members/library/permissions-by-role API and hooks#169
refactor: remove unused team-members/library/permissions-by-role API and hooks#169dcoa wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 66 66
Lines 1525 1488 -37
Branches 386 358 -28
=======================================
- Hits 1486 1450 -36
+ Misses 39 38 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Deletes dead data-layer code that's no longer referenced after the team/roles views were reworked: three API functions, three React Query hooks, their tests, and the now-orphaned types.
What's removed & why
getTeamMembers,getLibrary,getPermissionsByRole, plus their response/param types (GetTeamMembersResponse, PermissionsByRole). Also drops the now-unusedgetStudioApiUrlandLibraryMetadata/TeamMemberimports.useTeamMembers,usePermissionsByRole,useLibraryand their query keys; simplifies theonSettledcache invalidation inuseAssignTeamMembersRole/useRevokeUserRoles(no more per-scope teamMembers/permissionsByRole invalidation); routes the scopes query key throughauthzQueryKeys.scopes(params).getStudioApiUrl.TeamMemberandLibraryMetadatainterfaces.data/api.test.tsx,data/hooks.test.tsx).Depends on:
ContextTypewhich is introduced in #164Quality gate will fail until dependency is merged
AI use acknowledgement
Supported by Claude Code