Repository navigation
fix: drop uv run from Makefile - #449
Conversation
Makefile now assumes an already-synced/activated local env; uv run stays in CI workflow steps only. See openedx/ccx-keys#190 (review comment r4097501942). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Summary
This repo's Python-tooling-modernization Makefile (part of openedx/public-engineering#506) merged before feanil settled a rule during review of openedx/ccx-keys#190: Makefile targets should not be prefixed with
uv run— the Makefile assumes an already-synced/activated local env, anduv runstays only in CI workflow YAML. See the discussion comment: openedx/ccx-keys#190 (comment)This is a small follow-up bringing this repo's Makefile in line with that rule.
uv run --with <tool> ...lines (ephemeral tools not in this repo's own dependency groups) are left untouched, since those are a different case.Test plan
make quality,make test, etc. still work in a synced local virtualenv (nouv runprefix needed since the env is already active)🤖 Generated with Claude Code