Skip to content

feat: move commonly used attributes from XModuleMixin to XBlock#906

Merged
irtazaakram merged 5 commits intomasterfrom
add-required-attrs
Apr 20, 2026
Merged

feat: move commonly used attributes from XModuleMixin to XBlock#906
irtazaakram merged 5 commits intomasterfrom
add-required-attrs

Conversation

@irtazaakram
Copy link
Copy Markdown
Member

This pull request is related to openedx/openedx-platform#38271

It moves a set of commonly used attributes out of the legacy XModuleMixin into XBlock, since they are not specific to XModule behavior and are widely relied upon across most XBlocks.

The update also includes corresponding tests (generated with assistance from Claude Code), which have been carefully reviewed and refined.

@irtazaakram irtazaakram self-assigned this Apr 15, 2026
@kdmccormick kdmccormick self-requested a review April 17, 2026 13:49
Copy link
Copy Markdown
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request, good to merge otherwise.

Comment thread xblock/core.py Outdated
Co-authored-by: Kyle McCormick <kyle@axim.org>
@irtazaakram irtazaakram merged commit a82e2d1 into master Apr 20, 2026
6 checks passed
@irtazaakram irtazaakram deleted the add-required-attrs branch April 20, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants