Skip to content

Build own OpenSSL on manylinux_2_28 instead of using system package - #1281

Closed
tvasenin wants to merge 1 commit into
opencv:4.xfrom
tvasenin:fisp-selftest-failure-fix
Closed

tvasenin wants to merge 1 commit into
opencv:4.xfrom
tvasenin:fisp-selftest-failure-fix

Conversation

@tvasenin

Copy link
Copy Markdown
Contributor

Fixes FIPS SELFTEST FAILURE on FIPS-enabled non-RHEL systems (#1191)

Fixes FIPS SELFTEST FAILURE on FIPS-enabled non-RHEL systems (opencv#1191)

@MatchaOnMuffins MatchaOnMuffins left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Wondering if you could add a regression test, something simple like

OPENSSL_FORCE_FIPS_MODE=1 python -c "import cv2"

@tvasenin

Copy link
Copy Markdown
Contributor Author

Looks good! Wondering if you could add a regression test, something simple like

OPENSSL_FORCE_FIPS_MODE=1 python -c "import cv2"

I've just copied the OpenSSL build parts from the existing manylinux2014 Dockerfiles -- they didn't have such test, and adding new tests is out of scope of this PR.

@tvasenin

Copy link
Copy Markdown
Contributor Author

@asmorkalov Could you please review/merge this?

@asmorkalov

Copy link
Copy Markdown
Collaborator

@tvasenin Thanks for the contribution! We included your fix into #1288 to reduce docker image rebuilds. It'll be a part of commming 5.1.0 soon.

@asmorkalov asmorkalov closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants