Skip to content

distribution: Change from blame to rendered URI for image-index#47

Merged
stevvooe merged 1 commit into
opencontainers:add-distribution-proposalfrom
wking:distribution-image-index-blame
Mar 14, 2018
Merged

distribution: Change from blame to rendered URI for image-index#47
stevvooe merged 1 commit into
opencontainers:add-distribution-proposalfrom
wking:distribution-image-index-blame

Conversation

@wking

@wking wking commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

We only need blame views when the Markdown does not provide a specific-enough anchor, and this is a link to the whole file.

Fixes the issue raised be @stevvooe here.

We only need blame views when the Markdown does not provide a
specific-enough anchor, and this is a link to the whole file.

Signed-off-by: W. Trevor King <wking@tremily.us>
@dmcgowan

dmcgowan commented Mar 7, 2018

Copy link
Copy Markdown
Member

LGTM

@mikebrow mikebrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wking

wking commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

@caniszczyk, did you want to merge this before the distribution vote hits its stride?

@stevvooe

Copy link
Copy Markdown
Contributor

LGTM

@stevvooe stevvooe merged commit e07b90e into opencontainers:add-distribution-proposal Mar 14, 2018
@wking wking deleted the distribution-image-index-blame branch April 4, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants